pt-table-checksum 2.1.4 doesn't detect diffs on Percona XtraDB Cluster nodes
Bug #1062563 reported by
Daniel Nichter
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser |
Bug Description
Although v2.1.4 supports Percona XtraDB Cluster, there's a bug that prevents it from detecting diffs on cluster nodes:
should be
because right after that assignment, cluster nodes are removed from $slave_lag_cxns, and if $slave_lag_cxns is a ref to $slaves, then removing nodes from it removes the nodes from $slaves, too, so the diffs check on $slaves has nothing to check.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-ptc-pxc-bug-1062563
- Daniel Nichter: Approve
-
Diff: 721 lines (+504/-21)8 files modifiedbin/pt-query-digest (+208/-6)
bin/pt-stalk (+113/-4)
bin/pt-table-checksum (+22/-7)
lib/RowChecksum.pm (+5/-0)
t/lib/RowChecksum.t (+45/-4)
t/pt-stalk/plugin.t (+74/-0)
t/pt-stalk/samples/plugin001.sh (+21/-0)
t/pt-table-checksum/bugs.t (+16/-0)
- Daniel Nichter: Approve
-
Diff: 12 lines (+1/-1)1 file modifiedbin/pt-table-checksum (+1/-1)
lp:~percona-toolkit-dev/percona-toolkit/fix-1062563-1063912-ptc-pxc-bugs
- Daniel Nichter: Approve
-
Diff: 1190 lines (+897/-95)10 files modifiedbin/pt-config-diff (+0/-15)
bin/pt-kill (+8/-19)
bin/pt-online-schema-change (+8/-19)
bin/pt-table-checksum (+144/-25)
lib/Cxn.pm (+0/-15)
lib/Percona/XtraDB/Cluster.pm (+123/-0)
lib/Sandbox.pm (+83/-2)
t/lib/Percona/XtraDB/Cluster-no-PXC.t (+88/-0)
t/lib/Percona/XtraDB/Cluster.t (+201/-0)
t/pt-table-checksum/pxc.t (+242/-0)
Changed in percona-toolkit: | |
assignee: | nobody → Daniel Nichter (daniel-nichter) |
summary: |
- pt-table-checksum v2.1.4 doesn't detect diffs on Percona XtraDB cluster + pt-table-checksum v2.1.4 doesn't detect diffs on Percona XtraDB Cluster nodes |
Changed in percona-toolkit: | |
milestone: | none → 2.1.5 |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
summary: |
- pt-table-checksum v2.1.4 doesn't detect diffs on Percona XtraDB Cluster + pt-table-checksum 2.1.4 doesn't detect diffs on Percona XtraDB Cluster nodes |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
(this was partially fixed in 2.1.5, tagging this to 2.1.6 so we remember to merge the rest of the fix)