pt-fk-error-logger --run-time works differently than pt-deadlock-logger --run-time
Bug #1056838 reported by
Brian Fraser
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter |
Bug Description
Well, really, it's --interval that's different, but it affects --run-time.
pt-deadlock-logger says this about --run-time:
"If L<"--run-time"> is specified but no L<"--interval"> is specified, a default 1 second interval will be used."
Which while a bit magical, does the right thing; Meanwhile, pt-fk-error-
(originally reported by Migual Angel Nieto)
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-fke-logger-2.2
- Brian Fraser (community): Approve
- Daniel Nichter: Approve
-
Diff: 3998 lines (+1891/-858)35 files modifiedbin/pt-archiver (+5/-4)
bin/pt-config-diff (+53/-34)
bin/pt-deadlock-logger (+734/-334)
bin/pt-duplicate-key-checker (+5/-8)
bin/pt-fifo-split (+5/-8)
bin/pt-find (+5/-8)
bin/pt-fk-error-logger (+489/-131)
bin/pt-heartbeat (+5/-4)
bin/pt-kill (+61/-21)
bin/pt-online-schema-change (+51/-21)
bin/pt-query-advisor (+5/-5)
bin/pt-query-digest (+5/-5)
bin/pt-show-grants (+5/-8)
bin/pt-slave-delay (+5/-5)
bin/pt-slave-find (+5/-8)
bin/pt-slave-restart (+5/-5)
bin/pt-stalk (+5/-1)
bin/pt-table-checksum (+51/-25)
bin/pt-table-sync (+5/-8)
bin/pt-table-usage (+5/-5)
bin/pt-upgrade (+5/-5)
bin/pt-variable-advisor (+5/-5)
bin/pt-visual-explain (+5/-8)
docs/percona-toolkit.pod (+28/-0)
lib/Cxn.pm (+48/-17)
lib/Runtime.pm (+23/-36)
t/lib/Cxn.t (+58/-2)
t/pt-deadlock-logger/basics.t (+54/-42)
t/pt-deadlock-logger/clear_deadlocks.t (+2/-5)
t/pt-deadlock-logger/create_dest_table.t (+12/-9)
t/pt-deadlock-logger/option_sanity.t (+1/-1)
t/pt-deadlock-logger/standard_options.t (+73/-38)
t/pt-fk-error-logger/basics.t (+66/-8)
t/pt-fk-error-logger/get_fk_error.t (+2/-2)
t/pt-fk-error-logger/standard_options.t (+0/-32)
lp:~percona-toolkit-dev/percona-toolkit/pt-deadlock-logger-2.2
- Daniel Nichter: Approve
-
Diff: 1800 lines (+900/-452)8 files modifiedbin/pt-deadlock-logger (+724/-342)
bin/pt-fk-error-logger (+2/-1)
lib/Cxn.pm (+32/-14)
t/pt-deadlock-logger/basics.t (+54/-42)
t/pt-deadlock-logger/clear_deadlocks.t (+2/-5)
t/pt-deadlock-logger/create_dest_table.t (+12/-9)
t/pt-deadlock-logger/option_sanity.t (+1/-1)
t/pt-deadlock-logger/standard_options.t (+73/-38)
Changed in percona-toolkit: | |
importance: | Undecided → Medium |
milestone: | none → 2.1.5 |
status: | New → Triaged |
tags: | added: pt-deadlock-logger pt-fk-error-logger |
Changed in percona-toolkit: | |
assignee: | nobody → Daniel Nichter (daniel-nichter) |
Changed in percona-toolkit: | |
status: | Triaged → In Progress |
Changed in percona-toolkit: | |
assignee: | nobody → Daniel Nichter (daniel-nichter) |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
After reviewing --run-time and --interval of these and all tools that have --run-time, my conclusion is that the option is only loosely standardized. Some tools have no default --run-time and run once then exit, others run forever. Some have a default value for --run-time. Then throw --interval into the mix and it's less standardized.
I think we should try to standardize it even more, but we can't do that for 2.1 because it would introduce a backwards- incompatability in one tool or another. So I'm going to retarget this to 2.2.