Percona Toolkit moved to https://jira.percona.com/projects/PT

pt-online-schema-change --quiet doesn't disable --progress

Bug #1039541 reported by Baron Schwartz on 2012-08-21

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Percona Toolkit moved to https://jira.percona.com/projects/PT	Fix Released	Low	Daniel Nichter	Percona Toolkit moved to https://jira.percona.com/projects/PT 2.1.6

Unless I'm reading the code wrong, progress reports will happen even when --quiet is specified, which is bad for cron jobs.

I'll attach a patch against 2.1.3.

Tags:

Merged into lp:percona-toolkit/2.1 at revision 426

Daniel Nichter: Approve on 2012-10-22

Revision history for this message

Baron Schwartz (baron-xaprb) wrote on 2012-08-21:

Revision history for this message

Brian Fraser (fraserbn) wrote on 2012-08-29:

Odd. I reached the same conclussion as you, but even without the patch, looks like progress reports aren't printed if --quiet is specified?

Revision history for this message

Daniel Nichter (daniel-nichter) wrote on 2012-08-29:

Chances are this affects all the tools I just tagged. I don't ever recall conditionalizing --progress on --quiet.

tags:	added: pt-archiver pt-index-usage pt-online-schema-change pt-trend wrong-behavior
Changed in percona-toolkit:
status:	New → Confirmed

Daniel Nichter (daniel-nichter) on 2012-10-13

tags:	added: quiet removed: wrong-behavior
Changed in percona-toolkit:
milestone:	none → 2.1.6
importance:	Undecided → Low

Daniel Nichter (daniel-nichter) on 2012-10-22

Changed in percona-toolkit:
assignee:	nobody → Daniel Nichter (daniel-nichter)

Revision history for this message

Daniel Nichter (daniel-nichter) wrote on 2012-10-22:

This isn't a bug in pt-table-checksum because in --quiet: "(disables L<"--progress">)" which does disable --progress.

Revision history for this message

Daniel Nichter (daniel-nichter) wrote on 2012-10-22:

Only pt-osc had this problem.

summary:	- pt-table-checksum --quiet doesn't disable --progress + pt-online-schema-change --quiet doesn't disable --progress
tags:	removed: pt-archiver pt-index-usage pt-table-checksum pt-trend