pt-stalk does not get all InnoDB lock data
Bug #1035325 reported by
Baron Schwartz
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser | ||
Bug Description
I think gtowey or geodbz or someone might have reported this, too -- and Box has a patch in their Rain Gauge tool to address it. pt-stalk only gets the lock waits from the I_S tables for InnoDB. See the lock_waits() function. It would be best to capture the full contents of the INNODB_LOCK_WAITS as well as the INNODB_TRX and INNODB_LOCKS tables, as-is.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/collect-all-innodb-lock-data
- Daniel Nichter: Approve
-
Diff: 75 lines (+23/-6)3 files modifiedbin/pt-stalk (+8/-1)
lib/bash/collect.sh (+8/-1)
util/update-modules (+7/-4)
Revision history for this message
| Gavin Towey (gtowey) wrote | #1 |
| tags: | added: data-collection pt-stalk |
| Changed in percona-toolkit: | |
| status: | New → Triaged |
| Changed in percona-toolkit: | |
| milestone: | none → 2.1.4 |
| importance: | Undecided → Medium |
| Changed in percona-toolkit: | |
| assignee: | nobody → Daniel Nichter (daniel-nichter) |
Revision history for this message
| Daniel Nichter (daniel-nichter) wrote | #2 |
| Changed in percona-toolkit: | |
| status: | Triaged → In Progress |
| Changed in percona-toolkit: | |
| assignee: | Daniel Nichter (daniel-nichter) → Brian Fraser (fraserbn) |
Revision history for this message
| Brian Fraser (fraserbn) wrote | #3 |
| Changed in percona-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #4 |
To post a comment you must log in.
I agree; the raw output of INNODB_LOCKS is very useful for things like aggregating by table or schema, and the raw output of INNODB_TRX is necessary because SHOW ENGINE INNODB STATUS truncates queries, and SHOW PROCESSLIST doesn't include the innodb transaction id.