pt-mysql-summary doesn't handle renamed variables in Percona Server 5.5
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Brian Fraser |
Bug Description
The “Percona Server features” section in pt-mysql-summary doesn’t recognize renamed variables in Percona Server 5.5.
# Key Percona Server features #######
Table & Index Stats | Not Supported
Multiple I/O Threads | Enabled
Corruption Resilient | Not Supported
Durable Replication | Not Supported
Import InnoDB Tables | Not Supported
Fast Server Restarts | Not Supported
Enhanced Logging | Not Supported
Replica Perf Logging | Disabled
Response Time Hist. | Not Supported
Smooth Flushing | Not Supported
HandlerSocket NoSQL | Not Supported
Fast Hash UDFs | Unknown
# Plugins #######
InnoDB compression | ACTIVE
This is probably because of renamed variables. The last line in that sample also needs to be investigated, because apparently the server from which this sample was taken isn't even using the Barracuda file format.
Related branches
- Daniel Nichter: Approve
- Brian Fraser (community): Approve
-
Diff: 1439 lines (+1257/-31)10 files modifiedbin/pt-mysql-summary (+41/-11)
lib/bash/report_mysql_info.sh (+50/-11)
t/lib/bash/report_mysql_info.sh (+26/-1)
t/pt-mysql-summary/samples/expected_output_ps-5.1-features.txt (+12/-0)
t/pt-mysql-summary/samples/expected_output_ps-5.1-martin.txt (+12/-0)
t/pt-mysql-summary/samples/expected_output_ps-features.txt (+12/-0)
t/pt-mysql-summary/samples/expected_output_temp002.txt (+8/-8)
t/pt-mysql-summary/samples/percona-server-5.1-variables (+363/-0)
t/pt-mysql-summary/samples/percona-server-5.1-variables-martin (+353/-0)
t/pt-mysql-summary/samples/percona-server-5.5-variables (+380/-0)
tags: | added: percona-server |
Changed in percona-toolkit: | |
assignee: | nobody → Brian Fraser (fraserbn) |
Changed in percona-toolkit: | |
milestone: | none → 2.1.7 |
Changed in percona-toolkit: | |
milestone: | 2.1.7 → 2.1.8 |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
summary: |
- pt-mysql-summary not Percona Server 5.5-ready + pt-mysql-summary doesn't handle renamed variables in Percona Server 5.5 |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
The linked branch fixes the features part (Baron's analysis was correct -- the renamed variables weren't beign taken into account).
I don't think that the plugins bit is wrong -- 'ACTIVE' comes from MySQL itself, by doing SHOW PLUGINS and then awk'ing the line with INNODB_CMP.