pt-variable-advisor: contradictory ouput about binlogs

[Marcos Albe]

pt-variable-advisor returns contradictory assertions about binlogs (though is possible to deduct which one is wrong)

 pt-variable-advisor localhost
Code for rule concurrent_insert caused an error: Argument "AUTO" isn't numeric in numeric gt (>) at /usr/bin/pt-variable-advisor line 2770.
# WARN delay_key_write: MyISAM index blocks are never flushed until necessary.

# WARN innodb_log_file_size: The InnoDB log file size is set to its default value, which is not usable on production systems.

# NOTE innodb_max_dirty_pages_pct: The innodb_max_dirty_pages_pct is lower than the default.

# NOTE log_warnings-2: Log_warnings must be set greater than 1 to log unusual events such as aborted connections.

# WARN slave_net_timeout: This variable is set too high.

# NOTE sort_buffer_size-1: The sort_buffer_size variable should generally be left at its default unless an expert determines it is necessary to change it.

# NOTE innodb_data_file_path: Auto-extending InnoDB files can consume a lot of disk space that is very difficult to reclaim later.

# NOTE innodb_flush_method: Most production database servers that use InnoDB should set innodb_flush_method to O_DIRECT to avoid double-buffering, unless the I/O system is very low performance.

# WARN log_bin: Binary logging is disabled, so point-in-time recovery and replication are not possible.

# WARN sync_binlog: Binary logging is enabled, but sync_binlog isn't configured so that every transaction is flushed to the binary log for durability.

As you can see, last two are encountered opinions.

~ pt-variable-advisor --version
pt-variable-advisor 2.1.1

~ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 10.10
Release: 10.10
Codename: maverick

mysqld Ver 5.1.61-0ubuntu0.10.10.1 for debian-linux-gnu on x86_64 ((Ubuntu))

cat /etc/mysql/my.cnf
[mysqld]

# GENERAL #
user = mysql
default_storage_engine = InnoDB
# socket = /var/lib/mysql/mysql.sock
# pid-file = /var/lib/mysql/mysql.pid

# MyISAM #
key_buffer_size = 32M
myisam_recover = FORCE,BACKUP

# SAFETY #
max_allowed_packet = 16M
max_connect_errors = 1000000
skip_name_resolve
sysdate_is_now = 1
# innodb = FORCE
innodb_strict_mode = 1

# DATA STORAGE #
datadir = /var/lib/mysql

pid-file=/tmp/mysqld.pid

[Baron Schwartz (baron-xaprb)]

Thanks for the bug report.

[Baron Schwartz (baron-xaprb)]

I believe the root cause for this bug is the same as bug 844880, so I will mark it duplicate.