pt-table-sync --ignore-* options don't work with --replicate
Bug #1002365 reported by
Daniel Nichter
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Daniel Nichter | ||
2.0 |
Fix Released
|
High
|
Daniel Nichter | ||
2.1 |
Fix Released
|
High
|
Daniel Nichter |
Bug Description
There are tests for this (schema filters with --replicate), but there's no specific test for --replicate and --ignore-tables, so there could very well be a bug lurking here.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-sync-ignore-bug-1002365
- Daniel Nichter: Approve
-
Diff: 286 lines (+127/-47)3 files modifiedbin/pt-table-sync (+52/-44)
lib/TableChecksum.pm (+1/-2)
t/pt-table-sync/filters.t (+74/-1)
lp:~percona-toolkit-dev/percona-toolkit/fix-sync-ignore-bug-1002365-2.0
- Daniel Nichter: Approve
-
Diff: 2885 lines (+1834/-520)11 files modifiedbin/pt-table-sync (+580/-423)
lib/SchemaIterator.pm (+26/-44)
lib/TableChecksum.pm (+1/-2)
t/lib/SchemaIterator.t (+9/-50)
t/lib/samples/SchemaIterator/all-dbs-tbls-5.0.txt (+421/-0)
t/lib/samples/SchemaIterator/all-dbs-tbls.txt (+486/-0)
t/lib/samples/SchemaIterator/resume-from-ignored-sakila-payment-5.0.txt (+52/-0)
t/lib/samples/SchemaIterator/resume-from-ignored-sakila-payment.txt (+49/-0)
t/lib/samples/SchemaIterator/resume-from-sakila-payment-5.0.txt (+70/-0)
t/lib/samples/SchemaIterator/resume-from-sakila-payment.txt (+66/-0)
t/pt-table-sync/filters.t (+74/-1)
tags: | added: percona-21967 |
summary: |
- Some schema filters don't work with pt-table-sync --replicate + pt-table-sync --ignore-* options don't work with --replicate |
To post a comment you must log in.
I have reproduced this bug. Turns out, none of the --ignore-* options are applied to --replicate which uses filter_diffs() internally. It should use SchemaIterator: :table_ is_allowed( ) and friends instead.