Build error on FreeBSD with 5.6.38-83.0

[Thomas Babut]

I am trying to update the FreeBSD port of the percona56-server to 5.6.38-83.0 but I get this build error:

=========================================================================
[ 62%] Building CXX object sql/CMakeFiles/sql.dir/sql_builtin.cc.o
cd /usr/ports/databases/percona56-server/work/percona-server-5.6.38-83.0/sql && /usr/bin/c++ -DGTEST_USE_OWN_TR1_TUPLE=1 -DHAVE_CONFIG_H -DHAVE_EVENT_SCHEDULER -DHAVE_OPENSSL -DHAVE_POOL_OF_THREADS -DMYSQL_SERVER -I/usr/ports/databases/percona56-server/work/percona-server-5.6.38-83.0/include -I/usr/ports/databases/percona56-server/work/percona-server-5.6.38-83.0/sql -I/usr/ports/databases/percona56-server/work/percona-server-5.6.38-83.0/regex -I/usr/local/include -O2 -pipe -fstack-protector -fno-strict-aliasing -Wall -Wextra -Wformat-security -Wvla -Woverloaded-virtual -Wno-unused-parameter -Wno-null-conversion -Wno-unused-private-field -O2 -pipe -fstack-protector -fno-strict-aliasing -DDBUG_OFF -DMY_PTHREAD_FASTMUTEX=1 -o CMakeFiles/sql.dir/sql_builtin.cc.o -c /usr/ports/databases/percona56-server/work/percona-server-5.6.38-83.0/sql/sql_builtin.cc
In file included from /usr/ports/databases/percona56-server/work/percona-server-5.6.38-83.0/sql/sql_builtin.cc:16:
/usr/ports/databases/percona56-server/work/percona-server-5.6.38-83.0/include/mysql/plugin.h:649:1: error:
      unknown type name 'int64_t'; did you mean 'uint64_t'?
int64_t thd_get_query_id(const MYSQL_THD thd);
^~~~~~~
uint64_t
/usr/include/sys/endian.h:52:20: note: 'uint64_t' declared here
typedef __uint64_t uint64_t;
                        ^
1 error generated.
*** Error code 1
=========================================================================

Prior versions with the same FreeBSD patch set are building successfully. I can provide more data if needed.

Thanks in advance.

[Laurynas Biveinis (laurynas-biveinis)]

This is a regression by 584dc836d0a227bed36e7b60260f2f41bbc1a362 / https://github.com/percona/percona-server/commit/584dc836d0a227bed36e7b60260f2f41bbc1a362.

Vlad, can you take a look?

[Thomas Babut (mo-tbabut)]

In the meantime the port maintainer fixed the problem with the following patch:
https://svnweb.freebsd.org/ports/head/databases/percona56-server/files/patch-include__mysql__plugin.h?view=markup&pathrev=456486

[Vlad Lesin (vlad-lesin)]

The above patch leads to the following compilation error at least on Ubuntu 16.04 for 5.6:

CMake Error at ./cmake/do_abi_check.cmake:79 (MESSAGE):
  ABI check found difference between
  ./include/mysql/plugin_audit.h.pp
  and /ps-build-5.6/abi_check.out,
  compilation error file can be found here:
  /ps-build-5.6/plugin_audit.h.pp.err

Besides, plugins infrastructure was designed to be independent from MySQL code as well as possible, including my_global.h in plugin.h increases code coherence.

Currently we are working on another approach.

[Vlad Lesin (vlad-lesin)]

https://github.com/percona/percona-server/pull/2074
https://github.com/percona/percona-server/pull/2075

[Vlad Lesin (vlad-lesin)]

Could anybody confirm the fix works well for FreeBSD?

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2284