Percona Server moved to https://jira.percona.com/projects/PS

Some issues with THD sub statement save/restore for slow query log extensions

  1. Series 5.5
  2. Bug #1583589
Bug #1583589 reported by Laurynas Biveinis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Status tracked in 5.7
5.5
New
Undecided
Unassigned
5.6
Fix Released
Low
Laurynas Biveinis
Percona Server moved to https://jira.percona.com/projects/PS 5.6.31-77.0
5.7
Invalid
Low
Laurynas Biveinis

Bug Description

1) THD::reset_sub_statement_state_slow_extended copies m_sent_row_count and m_examined_row_count to backup. This is already done by its sole caller THD::reset_sub_statement_state.
2) THD::restore_sub_statement_state_slow_extended adds to m_sent_row_count and m_examined_row_count from backup. This already done by its sole caller THD::restore_sub_statement_state, resulting in those variables being added to twice.
3) These two methods can be made private.

Laurynas Biveinis (laurynas-biveinis)
tags: added: slow-extended
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

https://github.com/percona/percona-server/pull/532, https://github.com/percona/percona-server/pull/533

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2148

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.