Properly declare slow log support functions in sys_vars.cc for use in mysqld.cc
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Percona Server moved to https://jira.percona.com/projects/PS | Status tracked in 5.7 | |||||
5.1 |
Won't Fix
|
Low
|
Unassigned | |||
5.5 |
Triaged
|
Low
|
Unassigned | |||
5.6 |
Triaged
|
Low
|
Unassigned | |||
5.7 |
Triaged
|
Low
|
Unassigned |
Bug Description
Right now we have in mysqld.cc:
/* defined in sys_vars.cc */
extern void init_log_
extern void init_slow_
And in sys_vars.cc:
void init_log_
{
update_
}
void init_slow_
{
update_
}
First, the titles / bodies of the functions seem to be swapped. That's benign because the functions are always called together.
Second, they should be declared in sys_vars.h instead of mysqld.cc. Perhaps it is the update_... functions that should be exported from sys_vars, and then init_ functions would be static to mysqld.cc.
tags: | added: slow-extended |
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/ /jira.percona. com/browse/ PS-2001