Percona Server moved to https://jira.percona.com/projects/PS

Unnecessary 'volatile' keyword in mutex_struct

  1. Series 5.5
  2. Bug #1155632
Bug #1155632 reported by Alexey Kopytov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Invalid
Undecided
Unassigned
5.1
Won't Fix
Low
Unassigned
5.5
Triaged
Low
Unassigned
5.6
Invalid
Undecided
Unassigned

Bug Description

XtraDB changes (originally innodb_split_buf_pool_mutex.patch) add the 'volatile' keyword to the 'waiters' field of mutex_struct. While the purpose and benefits are unknown (it was introduced with revision 1 to innodb_split_buf_pool_mutex.patch and none of the upstream branches have that change), it can likely have a negative performance impact. This change needs to be reverted.

Tags: xtradb
Revision history for this message
Alexey Kopytov (akopytov) wrote :

It was probably an attempt to enforce atomic access :)

Laurynas Biveinis (laurynas-biveinis)
tags: added: xtradb
Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

lp:1099415 is another bug where volatile was added for btr_search_latch in one of the xtradb's patches, possibly for memory ordering.

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2914

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.