Unnecessary 'volatile' keyword in mutex_struct

Bug #1155632 reported by Alexey Kopytov on 2013-03-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Undecided
Unassigned
5.1
Low
Unassigned
5.5
Low
Unassigned
5.6
Undecided
Unassigned

Bug Description

XtraDB changes (originally innodb_split_buf_pool_mutex.patch) add the 'volatile' keyword to the 'waiters' field of mutex_struct. While the purpose and benefits are unknown (it was introduced with revision 1 to innodb_split_buf_pool_mutex.patch and none of the upstream branches have that change), it can likely have a negative performance impact. This change needs to be reverted.

Alexey Kopytov (akopytov) wrote :

It was probably an attempt to enforce atomic access :)

tags: added: xtradb

lp:1099415 is another bug where volatile was added for btr_search_latch in one of the xtradb's patches, possibly for memory ordering.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers