XA prepared transactions not properly recovered

[Laurynas Biveinis]

trx_lists_init_at_db_start does not add a transaction descriptor for XA PREPAREd transactions that have update (and not insert) undo records. As an example, their implicit X locks are invisible to other transactions, there might be other detrimental effects too.

This manifested as a failure of innodb.xa_recovery, which is a new upstream testcase in 5.5.44.

Fix is

diff --git a/storage/innobase/trx/trx0trx.c b/storage/innobase/trx/trx0trx.c
index 09f425c..7ed79d4 100644
--- a/storage/innobase/trx/trx0trx.c
+++ b/storage/innobase/trx/trx0trx.c
@@ -769,9 +769,9 @@ trx_lists_init_at_db_start(void)
                                                                " anyway.\n");

                                                        trx->state = TRX_ACTIVE;
- trx_reserve_descriptor(
- trx);
                                                }
+
+ trx_reserve_descriptor(trx);
                                        } else {
                                                trx->state
                                                        = TRX_COMMITTED_IN_MEMORY;

[Laurynas Biveinis (laurynas-biveinis)]

https://github.com/percona/percona-server/pull/94

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-3291