Percona Server with XtraDB

Make mysqlbinlog omit redundant `use` around BEGIN/SAVEPOINT/COMMIT/ROLLBACK in 5.0 binlogs

Reported by Oleg Tsarev on 2012-02-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Low
Unassigned
5.1
Low
Unassigned
5.5
Low
Unassigned

Bug Description

Make mysqlbinlog omit redundant `use` around BEGIN/SAVEPOINT/COMMIT/ROLLBACK in 5.0 binlogs.
This is a merge of lp:percona-server/rnt-5.1 patch mysqlbinlog_fix.patch.

MySQL 5.0 does not flag BEGIN/SAVEPOINT/COMMIT/ROLLBACK statements in its binlogs with LOG_EVENT_SUPPRESS_USE_F like 5.1+ does. This causes unnecessary `use` statements around such statements when the binlog is dumped by mysqlbinlog.

Fix by always suppressing the output of `use` for these statements.

Related branches

lp:~tsarev/percona-server/5.1-18205_01_mysqlbinlog_fix.patch
Merged into lp:percona-server/5.1 at revision 429
Laurynas Biveinis: Pending requested 2012-02-09
Stewart Smith: Pending requested 2012-02-09
Oleg Tsarev: Pending requested 2012-02-09
Alexey Kopytov: Pending requested 2012-02-09
Percona core: Pending requested 2012-02-07
Oleg Tsarev (tsarev) on 2012-02-09
no longer affects: percona-server/5.5

Marking as Invalid for 5.5 based on "no longer affects: percona-server/5.5 "

Raghu - that is not enough evidence to mark as "Invalid" for 5.5. is this implemented in the 5.5 upstream? Then it's either "Fix Released" or indeed "Invalid." Is this not implemented in 5.5? Then it needs a triage to "Won't Fix", "Wishlist" or "Low"/"Medium"/etc.

Alexey Kopytov (akopytov) wrote :

I think it still affects 5.5. The patch has not been merged to PS 5.5, and the test case modified by the patch in 5.1. still shows the redundant USE statements in the 5.5 tree.

@Laurynas @Alexey, sorry about that. I will test it and update it here.

By the way, I noticed a "Diff: 5486343 lines (has conflicts) " for percona-server merge, I wonder what that is :)

Raghu - it was the 5.1 branch proposed to merge to Percona Server 5.5 erroneously.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers