Percona Server with XtraDB

Make innodb_blocking_lru_restore / innodb_blocking_buffer_pool_restore accept arguments

Reported by Alexey Kopytov on 2011-10-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Low
George Ormond Lorch III
5.1
Low
George Ormond Lorch III
5.5
Low
George Ormond Lorch III

Bug Description

Currently innodb_blocking_lru_restore (in 5.1) and innodb_block_buffer_pool_restore (in 5.5) are defined as boolean options without arguments. That means specifying an ON/OFF argument in my.cnf or command line will not have any effect.

There's some inconsistency in how InnoDB options are defined. Some of them do allow an ON/OFF argument, while the other ones do not (not this only applies to my.cnf/command line option handling).

Examples of boolean InnoDB options w/o an argument (i.e. defined with PLUGIN_VAR_NOCMDARG):

innodb_checksums
innodb_doublewrite
innodb_file_per_table
innodb_locks_unsafe_for_binlog
innodb_adaptive_flushing
innodb_use_sys_malloc
innodb_random_read_ahead

Examples of boolean InnoDB options that may have an argument (i.e. defined with PLUGIN_VAR_OPCMDARG):

innodb_log_archive
innodb_rollback_on_timeout
innodb_status_file
innodb_stats_on_metadata
innodb_adaptive_hash_index

I think allowing an optional ON/OFFF argument for a boolean option leads to a more intuitive syntax. So innodb_blocking_{lru,buffer_pool}_restore should be changed to PLUGIN_VAR_OPCMDARG.

Stewart Smith (stewart) on 2012-06-15
Changed in percona-server:
status: Confirmed → Triaged
assignee: Alexey Kopytov (akopytov) → nobody
importance: Undecided → Low
Changed in percona-server:
assignee: nobody → George Ormond Lorch III (gl-az)
milestone: none → 5.1.64-13.5
Changed in percona-server:
status: Triaged → In Progress
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers