Percona Server moved to https://jira.percona.com/projects/PS

GCC 4.6 warnings

Bug #878164 reported by Laurynas Biveinis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Undecided
Laurynas Biveinis
Percona Server moved to https://jira.percona.com/projects/PS 5.5.20-24.1
5.1
Fix Released
Undecided
Laurynas Biveinis
Percona Server moved to https://jira.percona.com/projects/PS 5.1.60-13.1
5.5
Fix Released
Undecided
Laurynas Biveinis
Percona Server moved to https://jira.percona.com/projects/PS 5.5.20-24.1

Bug Description

GCC 4.6 has expanded diagnostics. New warnings reported:

Probably related to the dynamic row format patch:

/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_delete.c: In function ‘heap_delete’:
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_delete.c:25:8: warning: variable ‘rec_length’ set but not used [-Wunused-but-set-variable]

/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_write.c: In function ‘heap_write’:
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_write.c:37:8: warning: variable ‘rec_length’ set but not used [-Wunused-but-set-variable]
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_update.c: In function ‘heap_update’:
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_update.c:26:20: warning: variable ‘new_length’ set but not used [-Wunused-but-set-variable]
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_update.c:26:8: warning: variable ‘old_length’ set but not used [-Wunused-but-set-variable]

/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_test2.c: In function ‘main’:
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_test2.c:48:8: warning: variable ‘mem_per_keys’ set but not used [-Wunused-but-set-variable]

Probably related to the slow query log patches (or upstream):

/home/laurynas/percona/src/percona-server/Percona-Server/sql/log.cc: In member function ‘bool LOGGER::slow_log_print(THD*, const char*, uint, ulonglong)’:
/home/laurynas/percona/src/percona-server/Percona-Server/sql/log.cc:1212:12: warning: variable ‘current_time’ set but not used [-Wunused-but-set-variable]

Related branches

lp:~laurynas-biveinis/percona-server/compiler-warnings-5.1
Alexey Kopytov (community): Approve
Percona developers: Pending requested
Oleg Tsarev: Pending requested
Yasufumi Kinoshita: Pending requested
Diff: 490 lines (+87/-51)
9 files modified
patches/bugfix48929.patch (+21/-9)
patches/innodb_expand_fast_index_creation.patch (+2/-2)
patches/innodb_expand_import.patch (+1/-3)
patches/innodb_split_buf_pool_mutex.patch (+25/-30)
patches/innodb_thread_concurrency_timer_based.patch (+3/-3)
patches/mysql_remove_eol_carret.patch (+7/-1)
patches/query_cache_enhance.patch (+3/-3)
patches/series (+1/-0)
patches/warning_fixes.patch (+24/-0)
lp:~laurynas-biveinis/percona-server/compiler-warnings-5.5
Alexey Kopytov (community): Approve
Laurynas Biveinis (community): Needs Resubmitting
Diff: 605 lines (+127/-78)
12 files modified
patches/innodb_admin_command_base.patch (+5/-4)
patches/innodb_buffer_pool_pages_i_s.patch (+18/-6)
patches/innodb_expand_import.patch (+1/-3)
patches/innodb_extra_rseg.patch (+6/-2)
patches/innodb_show_sys_tables.patch (+36/-8)
patches/innodb_stats.patch (+14/-8)
patches/innodb_thread_concurrency_timer_based.patch (+3/-3)
patches/memory_dynamic_rows.patch (+15/-36)
patches/query_cache_enhance.patch (+1/-1)
patches/series (+1/-0)
patches/slow_extended.patch (+16/-7)
patches/warning_fixes.patch (+11/-0)
lp:~laurynas-biveinis/percona-server/warning-fixes-5.5-2
Alexey Kopytov (community): Approve
Diff: 769 lines (+73/-210)
3 files modified
patches/group_commit.patch (+1/-1)
patches/innodb_adaptive_hash_index_partitions.patch (+47/-184)
patches/innodb_split_buf_pool_mutex.patch (+25/-25)
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Regressed:

- sql/log.cc: In function ‘void mysql_bin_log_commit_pos(THD*, ulonglong*, const char**)’:
  sql/log.cc:7116:15: error: converting to non-pointer type ‘ulonglong
  {aka long long unsigned int}’ from NULL [-Werror=conversion-null]

- storage/innobase/btr/btr0sea.c: In function
  ‘btr_search_drop_page_hash_index’:
  storage/innobase/btr/btr0sea.c:1070:16: error: unused parameter
  ‘index_in’ [-Werror=unused-parameter]

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

storage/innobase/buf/buf0buf.c: In function ‘buf_pool_watch_set’:
storage/innobase/buf/buf0buf.c:1607: warning: ‘block_mutex’ may be used uninitialized in this function

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2699

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.