GCC 4.6 warnings

Bug #878164 reported by Laurynas Biveinis on 2011-10-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Undecided
Laurynas Biveinis
5.1
Undecided
Laurynas Biveinis
5.5
Undecided
Laurynas Biveinis

Bug Description

GCC 4.6 has expanded diagnostics. New warnings reported:

Probably related to the dynamic row format patch:

/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_delete.c: In function ‘heap_delete’:
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_delete.c:25:8: warning: variable ‘rec_length’ set but not used [-Wunused-but-set-variable]

/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_write.c: In function ‘heap_write’:
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_write.c:37:8: warning: variable ‘rec_length’ set but not used [-Wunused-but-set-variable]
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_update.c: In function ‘heap_update’:
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_update.c:26:20: warning: variable ‘new_length’ set but not used [-Wunused-but-set-variable]
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_update.c:26:8: warning: variable ‘old_length’ set but not used [-Wunused-but-set-variable]

/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_test2.c: In function ‘main’:
/home/laurynas/percona/src/percona-server/Percona-Server/storage/heap/hp_test2.c:48:8: warning: variable ‘mem_per_keys’ set but not used [-Wunused-but-set-variable]

Probably related to the slow query log patches (or upstream):

/home/laurynas/percona/src/percona-server/Percona-Server/sql/log.cc: In member function ‘bool LOGGER::slow_log_print(THD*, const char*, uint, ulonglong)’:
/home/laurynas/percona/src/percona-server/Percona-Server/sql/log.cc:1212:12: warning: variable ‘current_time’ set but not used [-Wunused-but-set-variable]

Related branches

lp:~laurynas-biveinis/percona-server/compiler-warnings-5.1
Merged into lp:percona-server/5.1 at revision 327
Alexey Kopytov: Approve on 2011-10-26
Percona developers: Pending requested 2011-10-25
Oleg Tsarev: Pending requested 2011-10-25
Yasufumi Kinoshita: Pending requested 2011-10-25
lp:~laurynas-biveinis/percona-server/compiler-warnings-5.5
Merged into lp:percona-server/5.5 at revision 199
Alexey Kopytov: Approve on 2011-12-15
Laurynas Biveinis: Resubmit on 2011-12-15
lp:~laurynas-biveinis/percona-server/warning-fixes-5.5-2
Merged into lp:percona-server/5.5 at revision 207
Alexey Kopytov: Approve on 2012-01-12

Regressed:

- sql/log.cc: In function ‘void mysql_bin_log_commit_pos(THD*, ulonglong*, const char**)’:
  sql/log.cc:7116:15: error: converting to non-pointer type ‘ulonglong
  {aka long long unsigned int}’ from NULL [-Werror=conversion-null]

- storage/innobase/btr/btr0sea.c: In function
  ‘btr_search_drop_page_hash_index’:
  storage/innobase/btr/btr0sea.c:1070:16: error: unused parameter
  ‘index_in’ [-Werror=unused-parameter]

storage/innobase/buf/buf0buf.c: In function ‘buf_pool_watch_set’:
storage/innobase/buf/buf0buf.c:1607: warning: ‘block_mutex’ may be used uninitialized in this function

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers