Percona Server with XtraDB

Atomic access issues with vars in response_time_distribution.patch

Reported by Laurynas Biveinis on 2011-10-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
High
Laurynas Biveinis
5.1
High
Laurynas Biveinis

Bug Description

Even with the bug 803865 fixed, couple of issues with atomic access in the response_time_distribution.patch remain:
1) The i386 CAS inline asm is missing "memory" and "volatile", see comments #10 and #11 at bug 803865. It is very likely that this bug is benign for now, still must be fixed.
2) The time_collector::m_count and m_total variables are declared volatile, which is wrong. Volatility has nothing to do with atomicity, volatile variables are those with unpredictable accesses. Here the accesses are very predictable.

Stewart Smith (stewart) on 2011-12-16
Changed in percona-server:
milestone: none → 5.5.19-25.0
milestone: 5.5.19-24.0 → 5.5.18-23.0

Upstream fix in 5.6.16 / 5.7.4.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers