innobackupex should not fail on missing files
Bug #859546 reported by
Alexey Kopytov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Undecided
|
Lachlan Mulcahy | ||
| 1.6 |
Fix Released
|
Undecided
|
Lachlan Mulcahy | ||
| 2.0 |
Fix Released
|
Undecided
|
Lachlan Mulcahy | ||
Bug Description
When copying InnoDB files in stream mode, innobackupex does a special check that a file exists when tar4ibd has failed. If it doesn't, it just means the table was dropped while innobackupex was copying other files, so the error is ignored.
A similar check is required when non-InnoDB files are being copied, i.e. in backup_files(). Currently, it first takes a list of files for a database, and then iterates that list. So if a table is dropped during that process, it would fail with an error.
Related branches
lp:~lachlan-mulcahy/percona-xtrabackup/1.6-bug859546
- Alexey Kopytov (community): Approve
-
Diff: 21 lines (+8/-1)1 file modifiedinnobackupex (+8/-1)
lp:~lachlan-mulcahy/percona-xtrabackup/1.7-bug859546
- Alexey Kopytov (community): Approve
-
Diff: 21 lines (+8/-1)1 file modifiedinnobackupex (+8/-1)
| Changed in percona-xtrabackup: | |
| status: | New → Confirmed |
Revision history for this message
| Lachlan Mulcahy (lachlan-mulcahy) wrote | #1 |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Funny. I just ran into this bug this last weekend and was about to patch it - Making some branches proposed to merge for a fix.
Basically just ignore error code 2 from tar (file not found) as non-fatal