Percona Server with XtraDB

Broken builds for some patches due to dependencies and wrong order in series

Reported by Alexey Kopytov on 2011-09-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Undecided
Alexey Kopytov
5.1
Undecided
Alexey Kopytov

Bug Description

Discovered when trying to modify innodb_lru_dump_restore.patch. The build failed with:

dict/dict0dict.c: In function ‘dict_reload_statistics’:
dict/dict0dict.c:4308: error: ‘dict_table_t’ has no member named ‘is_corrupt’
dict/dict0dict.c:4309: error: ‘srv_pass_corrupt_table’ undeclared (first use in this function)
dict/dict0dict.c:4309: error: (Each undeclared identifier is reported only once
dict/dict0dict.c:4309: error: for each function it appears in.)
dict/dict0dict.c: In function ‘dict_store_statistics’:
dict/dict0dict.c:4461: error: ‘dict_table_t’ has no member named ‘is_corrupt’
dict/dict0dict.c:4462: error: ‘srv_pass_corrupt_table’ undeclared (first use in this function)

'is_corrupt' and ‘srv_pass_corrupt_table’ are declared in innodb_pass_corrupt_table.patch, but are used in innodb_stats.patch which is 8 patches behind innodb_pass_corrupt_table.patch in series. So essentially all of the following patches cannot be built (and thus, worked on) independently:

innodb_stats.patch
innodb_recovery_patches.patch
innodb_purge_thread.patch
innodb_admin_command_base.patch
innodb_show_lock_name.patch
innodb_extend_slow.patch
innodb_lru_dump_restore.patch
innodb_separate_doublewrite.patch

The solution is probably to move innodb_stats.patch after innodb_pass_corrupt_table.patch, then fix a number of conflicts due to different context lines, then regenerate file offsets and hope no other patches get broken due to other dependencies.

Changed in percona-server:
status: New → Fix Committed
assignee: nobody → Alexey Kopytov (akopytov)
Changed in percona-server:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers