install_tests.sh fails due to bashism

Bug #790199 reported by Laurynas Biveinis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Undecided
Oleg Tsarev
5.1
Fix Released
Undecided
Oleg Tsarev
5.5
Fix Released
Undecided
Oleg Tsarev

Bug Description

Running install_tests.sh directly or by make tests fails with

laurynas@laurynas-ThinkPad-T410:~/percona/src/atomic-fixes-5.1$ ./install_tests.sh
./install_tests.sh: 29: let: not found
./install_tests.sh: 31: current: parameter not set

The first line of the script say #!/bin/sh . I suspect that "let" is bash-specific construct. If the script is run with bash, then it runs OK:
bash ./install_tests.sh
...tons of OK output...

I believe this is introduced by the fix to bug 782391.

Revision history for this message
Stewart Smith (stewart) wrote :

So this appears to be fixed in 5.1 trunk (by Nacho in release branch). So perhaps we should mark as fix released and assign to next milestone (5.1.58)

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Is requiring bash the best fix? Oleg made a fix that rewrites bash-specific construct in sh.

Revision history for this message
Stewart Smith (stewart) wrote :

that's okay too.... either way is okay with me (as long as it works on all our supported platforms :)

Oleg Tsarev (tsarev)
Changed in percona-server:
assignee: nobody → Oleg Tsarev (tsarev)
status: New → In Progress
Oleg Tsarev (tsarev)
Changed in percona-server:
status: In Progress → Fix Committed
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2640

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.