Build warnings introduced by userstat.patch
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Percona Server |
Low
|
Alexey Kopytov | ||
| | 5.1 |
Undecided
|
Unassigned | ||
| | 5.5 |
Low
|
Alexey Kopytov | ||
| | 5.6 |
Low
|
Alexey Kopytov | ||
Bug Description
Reporting the userstat.patch warnings as a separate bug per Yasufumi's request.
The following warnings are introduced by the patch when building on any non-Linux platform:
sql_parse.cc: In function ‘void mysql_parse(THD*, char*, uint, const char**)’:
sql_parse.cc:6142: warning: unused variable ‘tp’
sql_prepare.cc: In function ‘void mysqld_
sql_prepare.
sql_prepare.cc: In function ‘void mysqld_
sql_prepare.
sql_prepare.cc: In function ‘void mysqld_
sql_prepare.
sql_prepare.cc: In function ‘void mysqld_
sql_prepare.
Related branches
- Alexey Kopytov (community): Approve on 2011-02-03
- Percona developers: Pending requested 2011-02-02
-
Diff: 1414 lines (+411/-238)15 files modifiedinnodb_dict_size_limit.patch (+128/-81)
innodb_expand_import.patch (+2/-2)
innodb_extend_slow.patch (+4/-17)
innodb_files_extend.patch (+63/-9)
innodb_fix_misc.patch (+21/-1)
innodb_io_patches.patch (+14/-10)
innodb_lru_dump_restore.patch (+8/-25)
innodb_pass_corrupt_table.patch (+3/-3)
innodb_purge_thread.patch (+6/-6)
innodb_separate_doublewrite.patch (+12/-4)
innodb_show_lock_name.patch (+62/-22)
innodb_split_buf_pool_mutex.patch (+63/-43)
innodb_stats.patch (+1/-1)
profiling_slow.patch (+1/-1)
userstat.patch (+23/-13)
| Changed in percona-server: | |
| assignee: | nobody → Yasufumi Kinoshita (yasufumi-kinoshita) |
| Changed in percona-server: | |
| status: | New → Fix Committed |
| Changed in percona-server: | |
| status: | Fix Committed → Fix Released |
| Alexey Kopytov (akopytov) wrote : | #2 |
This bug was fixed only in 5.1, but not in 5.5 (so it also made it to 5.6).
It is a bit mysterious how I didn't notice it earlier. I'm fairly sure I could build both 5.5 and 5.6 in debug configuration and maintainer mode enabled until recently. It now fails for me with exactly the same symptoms, though the build environment seems to be the same.
I will fix also for 5.5.x soon