Response time distribution doesn't check ability "gcc atomic built in"

[Oleg Tsarev]

Response time distribution patch use gcc atomic builtin, but doesn't check ability.
Suggested fix (alternatives):
1) Percona require this ability:
#ifdef GCC_ATOMIC_BUILTIN
...
#else
#error ....
#endif
2) autotools check this ability, and feature are disabled if builtin unaccessable
3) user can change behavior if patch: --with-response-time-distribution=[none]|gcc-atomic|mutex

What better?

[Vadim Tkachenko (vadim-tk)]

I think checking with autotools is good enough

On Mon, Sep 27, 2010 at 8:22 AM, Oleg Tsarev <email address hidden> wrote:
> Public bug reported:
>
> Response time distribution patch use gcc atomic builtin, but doesn't check ability.
> Suggested fix (alternatives):
> 1) Percona require this ability:
> #ifdef GCC_ATOMIC_BUILTIN
> ...
> #else
> #error ....
> #endif
> 2) autotools check this ability, and feature are disabled if builtin unaccessable
> 3) user can change behavior if patch: --with-response-time-distribution=[none]|gcc-atomic|mutex
>
> What better?
>
> ** Affects: percona-server
>     Importance: Medium
>     Assignee: Oleg Tsarev (tsarev)
>         Status: Confirmed
>
> ** Changed in: percona-server
>     Assignee: (unassigned) => Oleg Tsarev (tsarev)
>
> ** Changed in: percona-server
>   Importance: Undecided => Medium
>
> ** Changed in: percona-server
>       Status: New => Confirmed
>
> ** Changed in: percona-server
>    Milestone: None => 5.1.50-12.1
>
> --
> Response time distribution doesn't check ability "gcc atomic built in"
> https://bugs.launchpad.net/bugs/649000
> You received this bug notification because you are a member of Percona
> developers, which is the registrant for Percona Server.
>
> Status in Percona Server with XtraDB: Confirmed
>
> Bug description:
> Response time distribution patch use gcc atomic builtin, but doesn't check ability.
> Suggested fix (alternatives):
> 1) Percona require this ability:
> #ifdef GCC_ATOMIC_BUILTIN
> ...
> #else
> #error ....
> #endif
> 2) autotools check this ability, and feature are disabled if builtin unaccessable
> 3) user can change behavior if patch: --with-response-time-distribution=[none]|gcc-atomic|mutex
>
> What better?
>
>
>

--
Vadim Tkachenko, CTO, Percona Inc.
Phone [phone],  Skype: vadimtk153
Schedule meeting: http://tungle.me/VadimTkachenko