Percona Server with XtraDB

mysql_remove_eol_carret.patch change default path

Reported by Yasufumi Kinoshita on 2010-08-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Status tracked in 5.6
5.1
Undecided
Unassigned
5.5
Undecided
Unassigned
5.6
Undecided
Unassigned

Bug Description

mysql_remove_eol_carret.patch

@@ -1434,6 +1436,10 @@
    NO_ARG, 1, 0, 0, 0, 0, 0},
   {"skip-line-numbers", 'L', "Don't write line number for errors.", 0, 0, 0, GET_NO_ARG,
    NO_ARG, 0, 0, 0, 0, 0, 0},
+ {"remove-eol-carret", OPT_REMOVE_EOL_CARRET, "Remove \\r before \\n in batch mode",
+ (uchar**)&opt_remove_eol_carret , (uchar**)&opt_remove_eol_carret, 0,
+ GET_BOOL,
+ NO_ARG, 0, 0, 0, 0, 0, 0},
   {"unbuffered", 'n', "Flush buffer after each query.", &unbuffered,
    &unbuffered, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
   {"column-names", OPT_COLUMN_NAMES, "Write column names in results.",

--> opt_remove_eol_carret is 0.

@@ -51,7 +53,7 @@
   if (!(pos=intern_read_line(line_buff,&out_length, truncated)))
     return 0;
   if (out_length && pos[out_length-1] == '\n')
- if (--out_length && pos[out_length-1] == '\r') /* Remove '\n' */
+ if (--out_length && opt_remove_eol_carret && pos[out_length-1] == '\r') /* Remove '\n' */
       out_length--; /* Remove '\r' */
   line_buff->read_length=out_length;
   pos[out_length]=0;

--> if the default setting, the "if()" condition are changed to "always false".

Is it correct as intention of the patch?
Does it not affect to current users any?

Percona (percona-team) on 2010-08-30
Changed in percona-server:
status: New → Confirmed
importance: Undecided → Medium
Percona (percona-team) on 2010-08-31
Changed in percona-server:
assignee: nobody → Sasha Pachev (sasha-pachev)
milestone: none → 5.1-12.0
Changed in percona-server:
milestone: 5.1-12.0 → 5.1.50-12.1
Changed in percona-server:
status: Confirmed → Fix Committed
Stewart Smith (stewart) wrote :

has fix been released? should this be "fix released"?

Stewart Smith (stewart) on 2011-06-02
Changed in percona-server:
milestone: 5.1.50-12.1 → none
Changed in percona-server:
assignee: Sasha Pachev (sasha-pachev) → nobody
importance: Medium → Undecided
status: Fix Committed → New
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers