Tokudb does not build when WITH_VALGRIND=1

Bug #1729321 reported by Robert Golebiowski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Status tracked in 5.7
5.5
Invalid
Undecided
Unassigned
5.6
New
Undecided
Unassigned
5.7
New
High
George Ormond Lorch III

Bug Description

When TokuDB is build with WITH_VALGRIND=1, compiler gives this error:
percona-server/storage/tokudb/PerconaFT/portability/toku_race_tools.h:93:0: error: "RUNNING_ON_VALGRIND" redefined

I came up with this workaround:

(diff for main CMakeLists.txt):

OPTION(WITHOUT_SERVER OFF)
IF(UNIX)
   OPTION(WITH_VALGRIND "Valgrind instrumentation" OFF)
+ IF (WITH_VALGRIND)
+ ADD_DEFINITIONS(-DUSE_VALGRIND)
+ ENDIF()
 ENDIF()
 IF(WIN32)
   OPTION(WITH_MSCRT_DEBUG "MS Visual Studio Debug CRT instrumentation" OFF)

Tags: tokudb
Changed in percona-server:
importance: Undecided → High
assignee: nobody → George Ormond Lorch III (gl-az)
tags: added: tokudb
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1121

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.