Cmake sometimes generates garbage in 'unittest/gunit/CMakeFiles/merge_large_tests-t.dir/build.make' after downloading 'googletest-release-1.8.0.zip'

[Yura Sorokin]

When '-DENABLE_DOWNLOADS=1' option is specified and there is no local version of 'source_downloads/googletest-release-1.8.0.zip', sometimes cmake generates corrupted 'unittest/gunit/CMakeFiles/merge_large_tests-t.dir/build.make' makefile which includes SSL handshake garbage.

*********************************
# External object files for target merge_large_tests-t
merge_large_tests__t_EXTERNAL_OBJECTS =

unittest/gunit/SSLv3,\ TLS\ handshake,\ Client\ hello\ (1):

merge_large_tests-t: unittest/gunit/CMakeFiles/merge_large_tests-t.dir/merge_large_tests.cc.o
unittest/gunit/SSLv3,\ TLS\ handshake,\ Client\ hello\ (1):

merge_large_tests-t: unittest/gunit/CMakeFiles/merge_large_tests-t.dir/__/__/storage/example/ha_example.cc.o
unittest/gunit/SSLv3,\ TLS\ handshake,\ Client\ hello\ (1):

merge_large_tests-t: unittest/gunit/CMakeFiles/merge_large_tests-t.dir/build.make
unittest/gunit/SSLv3,\ TLS\ handshake,\ Client\ hello\ (1):

merge_large_tests-t: sql/libsql.a
*********************************

This causes build failures.

Observed on 5.6.35 on centos5-64, debian-wheezy-x64 and ubuntu-xenial-64bit.

[Yura Sorokin (yura-sorokin)]

This issue could be connected with outdated version of cmake and/or curl (used for downloading) on some platforms.

[Yura Sorokin (yura-sorokin)]

This issue started to appear after merging mysql-5.6.35. In particular commit 9a05426(https://github.com/mysql/mysql-server/commit/9a05426) changes the URL from where GMOCK package is downloaded:
from
http://googlemock.googlecode.com
to
https://github.com/google/googletest/archive/

So, the issue could be with one of the github mirrors implementing SSL handshake incorrectly.

[Laurynas Biveinis (laurynas-biveinis)]

Upstream?

[Yura Sorokin (yura-sorokin)]

As a workaround, 'googletest-release-1.8.0.zip' can be pre-downloaded into 'source_downloads' using 'wget' just before running 'cmake'.

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-3625