Audit Log Creates Unparsable Date String
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Percona Server moved to https://jira.percona.com/projects/PS | Status tracked in 5.7 | |||||
5.5 |
Triaged
|
Medium
|
Unassigned | |||
5.6 |
Triaged
|
Medium
|
Unassigned | |||
5.7 |
Triaged
|
Medium
|
Unassigned |
Bug Description
The audit log currently produces time stamps like this: 2016-11-15T12:12:34 UTC
This is not a recognized standard for ISO8601. (https:/
-- QUOTE
If the time is in UTC, add a Z directly after the time without a space. Z is the zone designator for the zero UTC offset. "09:30 UTC" is therefore represented as "09:30Z" or "0930Z". "14:45:15 UTC" would be "14:45:15Z" or "144515Z".
-- END
Please consider the following patch to correct this:
diff --git a/audit_log.c b/audit_log.c
index 39078fa..4c3224d 100644
--- a/audit_log.c
+++ b/audit_log.c
@@ -134,7 +134,7 @@ char *make_timestamp
struct tm tm;
memset(&tm, 0, sizeof(tm));
- strftime(buf, buf_len, "%FT%T UTC", gmtime_r(&t, &tm));
+ strftime(buf, buf_len, "%FT%TZ", gmtime_r(&t, &tm));
return buf;
}
tags: | added: audit |
Since simply changing timestamp format may break existent applications I believe this should be implemented as an option.
If we believe going standard is right way to fix Audit plugin such change should be done only in the next major version.