Percona Server 5.6.26-74.0 fails to compile from source on FreeBSD

[Thomas Babut]

The new release fails to compile from source on FreeBSD 9.3 and 10.2 (AMD64) with the following error:

Linking C executable comp_sql
[ 5%] Building C object zlib/CMakeFiles/zlib.dir/compress.c.o
[ 5%] Building C object libservices/CMakeFiles/mysqlservices.dir/my_thread_scheduler_service.c.o
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c: In function 'vio_client_must_be_proxied':
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:709: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:709: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:709: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:710: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:710: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:711: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:712: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:712: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:713: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:714: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:714: error: 'struct in6_addr' has no member named 's6_addr32'
/usr/ports/databases/percona56-client/work/percona-server-5.6.26-74.0/vio/viosocket.c:715: error: 'struct in6_addr' has no member named 's6_addr32'
*** [vio/CMakeFiles/vio.dir/viosocket.c.o] Error code 1
[ 5%] Built target comp_sql
1 error
*** [vio/CMakeFiles/vio.dir/all] Error code 2

[Laurynas Biveinis (laurynas-biveinis)]

Looks like a regression from the proxy protocol support patch. FreeBSD is not one of our supported platforms but if someone sends us a patch that adds proper in6_addr there, we could apply it.

[Valerii Kravchuk (valerii-kravchuk)]

On FreeBSD the structure is defined like this in netinet6/in6.h:

   92 /*
   93 * IPv6 address
   94 */
   95 struct in6_addr {
   96 union {
   97 uint8_t __u6_addr8[16];
   98 uint16_t __u6_addr16[8];
   99 uint32_t __u6_addr32[4];
  100 } __u6_addr; /* 128-bit IP6 address */
  101 };
  102
  103 #define s6_addr __u6_addr.__u6_addr8
  104 #ifdef _KERNEL /* XXX nonstandard */
  105 #define s6_addr8 __u6_addr.__u6_addr8
  106 #define s6_addr16 __u6_addr.__u6_addr16
  107 #define s6_addr32 __u6_addr.__u6_addr32
  108 #endif

[Ceyu (cemil)]

Put the "#define" directives within struct in netinet6/in6.h like this:

 /*
   * IPv6 address
   */
    struct in6_addr {
   union {
   uint8_t __u6_addr8[16];
   uint16_t __u6_addr16[8];
   uint32_t __u6_addr32[4];
  } __u6_addr; /* 128-bit IP6 address */

#define s6_addr __u6_addr.__u6_addr8
#ifdef _KERNEL /* XXX nonstandard */
#define s6_addr8 __u6_addr.__u6_addr8
#define s6_addr16 __u6_addr.__u6_addr16
#define s6_addr32 __u6_addr.__u6_addr32
#endif

};

[Thomas Babut (thbabut)]

Although I'm not a developer at all, I've created a patch that apparently works. I am testing a slave with this patch without any problems so far. But I cannot say anything about the functionality of the ipv6/proxy part. There is certainly a better place for the additional code also. Perhaps it is a only starting point. Thanks in advance.

[Ceyu (cemil)]

Addition to #3
I forgot to comment out the following:

/* #ifdef _KERNEL */
..
..
/* #endif */

[Thomas Babut (thbabut)]

The port maintainer at FreeBSD has modified my patch a little bit:
https://svnweb.freebsd.org/ports/head/databases/percona56-server/files/patch-sql_mysqld.cc?view=markup&pathrev=399074
https://svnweb.freebsd.org/ports/head/databases/percona56-server/files/patch-vio_viosocket.c?view=markup&pathrev=399074

Perhaps you could adopt these two patches. Thanks.

[Alexander Pyhalov (alp-rsu)]

Please, note that second patch should be modified to work on illumos (it should look like the first one).

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2124