CMakeLists.txt for "tokudb-backup-plugin" does not include Valgrind dependency

Bug #1494283 reported by Yura Sorokin
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Medium
Tomislav Plavcic
5.6
Fix Released
Medium
Tomislav Plavcic

Bug Description

Tried to build percona-servrer 5.6 (commit 7416cc0) on a CentOS 7 machine without "valgring-devel" package installed.

cmake ../percona-server \
 -DBUILD_CONFIG=mysql_release \
 -DCMAKE_BUILD_TYPE=Debug \
 -DDEBUG_EXTNAME=OFF \
 -DWITH_EMBEDDED_SERVER=OFF \
 -DFEATURE_SET=community \
 -DENABLE_DTRACE=OFF \
 -DWITH_SSL=system \
 -DWITH_PAM=ON \
 -DWITH_INNODB_MEMCACHED=ON

Please, notice no "-DWITH_VALGRING=ON" option.

make

[ 93%] Building CXX object plugin/tokudb-backup-plugin/Percona-TokuBackup/backup/CMakeFiles/HotBackup.dir/manager.cc.o
/home/yura/ws/percona-server/plugin/tokudb-backup-plugin/Percona-TokuBackup/backup/manager.cc:57:31: fatal error: valgrind/helgrind.h: No such file or directory
 #include <valgrind/helgrind.h>
                               ^
compilation terminated.
make[2]: *** [plugin/tokudb-backup-plugin/Percona-TokuBackup/backup/CMakeFiles/HotBackup.dir/manager.cc.o] Error 1
make[1]: *** [plugin/tokudb-backup-plugin/Percona-TokuBackup/backup/CMakeFiles/HotBackup.dir/all] Error 2
make: *** [all] Error 2

Tags: tokudb
tags: added: tokudb
Revision history for this message
Tomislav Plavcic (tplavcic) wrote :

Seems to me this is actually not in a tokudb-backup-plugin but Percona-TokuBackup which means it's in a submodule and is used in other Toku products and not only in PS - solution should take this into consideration - not sure if it makes a difference but just a note.

Revision history for this message
Ken Zalewski (ken-zalewski) wrote :

Same problem here.

<valgrind/helgrind.h> is required, since it is not wrapped in any conditional logic.

Changed in percona-server:
assignee: nobody → Tomislav Plavcic (tplavcic)
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Tomislav Plavcic (tplavcic) wrote :
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1650

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers