build-binary.sh should abort if TokuDB source dir is present but its build failed

[Laurynas Biveinis]

The build-binary.sh script uses whatever the default system GCC is, resulting in TokuDB build failure if it is < 4.7.

Affected systems: Precise, CentOS 5, CentOS 6, and Squeeze.

Perhaps this is possible to fix at CMake level, if not, or if that has other undesirable consequences, then in build-binary.sh.

[Tomislav Plavcic (tplavcic)]

It was fixed in our jenkins jobs - not sure its good to handle this in cmake or build-binary.sh - could possibly have too many combinations and variances since we don't know in which ways and locations people can install alternative compiler.

[Laurynas Biveinis (laurynas-biveinis)]

OK, then I suggest that build-binary.sh detects that it needs to build TokuDB and aborts if it failed to do so (as opposed to the current behavior of silently removing TokuDB from the build).

I.e. if test -d $SOURCEDIR/storage/tokudb, then after the make ha_tokudb.so must be present.

[Laurynas Biveinis (laurynas-biveinis)]

Having second thoughts about the above suggestion too. If a single source tarball is used, then non-TokuDB platforms will fail to build it, probably not the desired behavior. Either needs something like --skip-tokudb, either the current setup is just fine.

[Tomislav Plavcic (tplavcic)]

We have two tarballs (we need to also because of legal reasons) - so if somebody wants to build PS+TokuDB on platforms which support it and it fails then there's some general problem that needs to be debuged, and if you don't want to build TokuDB or is unsupported platform you just use PS tarball without the other one.

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1580