Threadpool adds connection without notifying audit plugin

Bug #1282008 reported by fengyi on 2014-02-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Status tracked in 5.6
5.1
Undecided
Unassigned
5.5
Medium
Sergei Glushchenko
5.6
Medium
Sergei Glushchenko

Bug Description

MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd) should be called after login_connection in threadpool_add_connection.

Related branches

lp:~sergei.glushchenko/percona-server/5.5-ps-bug1282008
Laurynas Biveinis: Approve on 2014-03-17
lp:~sergei.glushchenko/percona-server/5.6-ps-bug1282008
Laurynas Biveinis: Approve on 2014-03-18

This is what we have in 5.6:

openxs@ao756:~/bzr/percona-5.6$ grep -rn "MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd)" *
sql/sql_connect.cc:1452: MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd);
sql/sql_audit.h:182:#define MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd) mysql_audit_notify(\
openxs@ao756:~/bzr/percona-5.6$ grep -rn login_connection * sql/threadpool_common.cc:215: if (!login_connection(thd))
sql/sql_connect.cc:1258: login_connection()
sql/sql_connect.cc:1270:bool login_connection(THD *thd)
sql/sql_connect.cc:1274: DBUG_ENTER("login_connection");
sql/sql_connect.cc:1275: DBUG_PRINT("info", ("login_connection called by thread %lu",
sql/sql_connect.cc:1451: rc= login_connection(thd);
sql/sql_connect.h:46:bool login_connection(THD *thd);

and 5.5:

openxs@ao756:~/bzr/percona-5.6$ cd ../percona-5.5
openxs@ao756:~/bzr/percona-5.5$ grep -rn "MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd)" *
sql/sql_connect.cc:1333: MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd);
sql/sql_audit.h:174:#define MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd) mysql_audit_notify(\
openxs@ao756:~/bzr/percona-5.5$ grep -rn login_connection * sql/threadpool_common.cc:150: if (!login_connection(thd))
sql/sql_connect.cc:1143: login_connection()
sql/sql_connect.cc:1155:bool login_connection(THD *thd)
sql/sql_connect.cc:1159: DBUG_ENTER("login_connection");
sql/sql_connect.cc:1160: DBUG_PRINT("info", ("login_connection called by thread %lu",
sql/sql_connect.cc:1332: rc= login_connection(thd);
sql/sql_connect.h:46:bool login_connection(THD *thd);

tags: added: threadpool
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers