Issue with PERCONA_INNODB_VERSION

Bug #1277383 reported by Raghavendra D Prabhu on 2014-02-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
High
Tomislav Plavcic
5.1
High
Tomislav Plavcic
5.5
High
Alexey Bychko
5.6
High
Tomislav Plavcic

Bug Description

Currently, PERCONA_INNODB_VERSION is passed through
CFLAGS/CXXFLAGS as "-DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION "
where $PERCONA_SERVER_VERSION is obtained as

PERCONA_SERVER_VERSION="$(grep ^PERCONA_SERVER_VERSION= "$SOURCEDIR/Makefile" | cut -d = -f 2)"

which for 5.5 is currently at 33.0

Next, there is

#ifndef PERCONA_INNODB_VERSION
#define PERCONA_INNODB_VERSION 29.3
#endif

in univ.i wherein it is defined as above.

So,

a) For Percona releases, the innodb version is set to release
versions and they are incremented (either the major/minor part of
it) at every release.

b) For those who don't use our Makefile, the univ.i will be out
of sync permanently.

Related branches

This is what we have for 5.5:

[openxs@chief percona-5.5]$ grep -rn PERCONA_INNODB_VERSION *
build-ps/build-rpm.sh:126:export CFLAGS="-fPIC -Wall -O3 -g -static-libgcc -fno-omit-frame-pointer -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CFLAGS:-}"
build-ps/build-rpm.sh:127:export CXXFLAGS="-O2 -fno-omit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fno-exceptions -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CXXFLAGS:-}"
build-ps/build-binary.sh:157:export CFLAGS="-fPIC -Wall -O3 -g -static-libgcc -fno-omit-frame-pointer -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CFLAGS:-}"
build-ps/build-binary.sh:158:export CXXFLAGS="-O2 -fno-omit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fno-exceptions -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CXXFLAGS:-}"
storage/innobase/include/univ.i:66:#ifndef PERCONA_INNODB_VERSION
storage/innobase/include/univ.i:67:#define PERCONA_INNODB_VERSION 29.3
storage/innobase/include/univ.i:70:#define INNODB_VERSION_STR MYSQL_SERVER_VERSION "-" IB_TO_STR(PERCONA_INNODB_VERSION)

For 5.6 we have:

[openxs@chief percona-5.6]$ grep -rn PERCONA_INNODB_VERSION *
build-ps/build-rpm.sh:126:export CFLAGS="-fPIC -Wall -O3 -g -static-libgcc -fno-omit-frame-pointer -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CFLAGS:-}"
build-ps/build-rpm.sh:127:export CXXFLAGS="-O2 -fno-omit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CXXFLAGS:-}"
build-ps/build-binary.sh:157:export CFLAGS="-fPIC -Wall -O3 -g -static-libgcc -fno-omit-frame-pointer -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CFLAGS:-}"
build-ps/build-binary.sh:158:export CXXFLAGS="-O2 -fno-omit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CXXFLAGS:-}"
storage/innobase/include/univ.i:49:#ifndef PERCONA_INNODB_VERSION
storage/innobase/include/univ.i:50:#define PERCONA_INNODB_VERSION 60.3
storage/innobase/include/univ.i:69: IB_TO_STR(PERCONA_INNODB_VERSION)

While in makefile we see:

PERCONA_SERVER_VERSION=rel62.0

tags: added: low-hanging-fruit pkg
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers