Percona Server moved to https://jira.percona.com/projects/PS

Issue with PERCONA_INNODB_VERSION

Bug #1277383 reported by Raghavendra D Prabhu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
High
Tomislav Plavcic
Percona Server moved to https://jira.percona.com/projects/PS 5.6.16-64.0
5.1
Fix Released
High
Tomislav Plavcic
Percona Server moved to https://jira.percona.com/projects/PS 5.1.73-14.12
5.5
Fix Released
High
Alexey Bychko
Percona Server moved to https://jira.percona.com/projects/PS 5.5.36-34.0
5.6
Fix Released
High
Tomislav Plavcic
Percona Server moved to https://jira.percona.com/projects/PS 5.6.16-64.0

Bug Description

Currently, PERCONA_INNODB_VERSION is passed through
CFLAGS/CXXFLAGS as "-DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION "
where $PERCONA_SERVER_VERSION is obtained as

PERCONA_SERVER_VERSION="$(grep ^PERCONA_SERVER_VERSION= "$SOURCEDIR/Makefile" | cut -d = -f 2)"

which for 5.5 is currently at 33.0

Next, there is

#ifndef PERCONA_INNODB_VERSION
#define PERCONA_INNODB_VERSION 29.3
#endif

in univ.i wherein it is defined as above.

So,

a) For Percona releases, the innodb version is set to release
versions and they are incremented (either the major/minor part of
it) at every release.

b) For those who don't use our Makefile, the univ.i will be out
of sync permanently.

Related branches

lp:~percona-core/percona-server/release-5.6.16-64.0
Laurynas Biveinis (community): Approve
Diff: 58 lines (+6/-7)
3 files modified
Makefile-ps (+2/-2)
build-ps/percona-server.spec (+3/-4)
storage/innobase/include/univ.i (+1/-1)
lp:~percona-core/percona-server/release-5.5.36-34.0
Laurynas Biveinis (community): Approve
Diff: 104 lines (+8/-15)
3 files modified
build-ps/debian/control (+1/-2)
build-ps/percona-server.spec (+6/-12)
storage/innobase/include/univ.i (+1/-1)
lp:~percona-core/percona-server/release-5.1.73-14.12
Laurynas Biveinis (community): Approve
Diff: 207 lines (+31/-15)
10 files modified
Makefile (+1/-1)
Percona-Server/storage/innodb_plugin/include/univ.i (+1/-1)
build/build-binary.sh (+1/-0)
build/build-shared-compat-rpm.sh (+1/-1)
build/debian/changelog (+12/-0)
build/debian/control (+3/-3)
build/debian/patches/33_scripts__mysql_create_system_tables__no_test.dpatch (+1/-1)
build/debian/rules (+3/-1)
build/percona-server.spec (+6/-5)
build/percona-shared-compat.spec (+2/-2)
Revision history for this message
Valerii Kravchuk (valerii-kravchuk) wrote :

This is what we have for 5.5:

[openxs@chief percona-5.5]$ grep -rn PERCONA_INNODB_VERSION *
build-ps/build-rpm.sh:126:export CFLAGS="-fPIC -Wall -O3 -g -static-libgcc -fno-omit-frame-pointer -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CFLAGS:-}"
build-ps/build-rpm.sh:127:export CXXFLAGS="-O2 -fno-omit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fno-exceptions -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CXXFLAGS:-}"
build-ps/build-binary.sh:157:export CFLAGS="-fPIC -Wall -O3 -g -static-libgcc -fno-omit-frame-pointer -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CFLAGS:-}"
build-ps/build-binary.sh:158:export CXXFLAGS="-O2 -fno-omit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fno-exceptions -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CXXFLAGS:-}"
storage/innobase/include/univ.i:66:#ifndef PERCONA_INNODB_VERSION
storage/innobase/include/univ.i:67:#define PERCONA_INNODB_VERSION 29.3
storage/innobase/include/univ.i:70:#define INNODB_VERSION_STR MYSQL_SERVER_VERSION "-" IB_TO_STR(PERCONA_INNODB_VERSION)

Revision history for this message
Valerii Kravchuk (valerii-kravchuk) wrote :

For 5.6 we have:

[openxs@chief percona-5.6]$ grep -rn PERCONA_INNODB_VERSION *
build-ps/build-rpm.sh:126:export CFLAGS="-fPIC -Wall -O3 -g -static-libgcc -fno-omit-frame-pointer -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CFLAGS:-}"
build-ps/build-rpm.sh:127:export CXXFLAGS="-O2 -fno-omit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CXXFLAGS:-}"
build-ps/build-binary.sh:157:export CFLAGS="-fPIC -Wall -O3 -g -static-libgcc -fno-omit-frame-pointer -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CFLAGS:-}"
build-ps/build-binary.sh:158:export CXXFLAGS="-O2 -fno-omit-frame-pointer -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -DPERCONA_INNODB_VERSION=$PERCONA_SERVER_VERSION $TARGET_CFLAGS ${CXXFLAGS:-}"
storage/innobase/include/univ.i:49:#ifndef PERCONA_INNODB_VERSION
storage/innobase/include/univ.i:50:#define PERCONA_INNODB_VERSION 60.3
storage/innobase/include/univ.i:69: IB_TO_STR(PERCONA_INNODB_VERSION)

While in makefile we see:

PERCONA_SERVER_VERSION=rel62.0

Laurynas Biveinis (laurynas-biveinis)
tags: added: low-hanging-fruit pkg
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-759

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.