Adjust perfschema autosizing for Percona Server mutexes

Bug #1264952 reported by Laurynas Biveinis on 2013-12-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Status tracked in 5.6
5.1
Undecided
Unassigned
5.5
Undecided
Unassigned
5.6
Low
Laurynas Biveinis

Bug Description

Currently sizing_growth testcase is recorded as

status
FAILED: heuristics need to be updated

which is caused by Percona Server hitting four instead of three mutexes in MySQL for opening a connection. The three MySQL mutexes being wait/synch/mutex/mysys/my_thread_var::mutex, wait/synch/mutex/mysys/THR_LOCK::mutex, wait/synch/mutex/sql/THD::LOCK_thd_data, and the fourth Percona Server mutex being wait/synch/mutex/sql/THD::LOCK_temporary_tables.

The comments in the testcase suggest trivially updating PFS autosizing heuristics in pfs_autosize.cc to account for four mutexes, so that the autosized performance_schema_max_mutex_instances presumably would do a bit better job.

I guess this has a negligible impact, but it's an easy fix and fixing it is probably a good idea as the current sizing_growth.result is recorded very counter-intuitively.

Related branches

lp:~laurynas-biveinis/percona-server/bug1264952
Merged into lp:percona-server at revision 529
Vlad Lesin: Approve (g2) on 2014-01-13
tags: added: merge-regression performance
tags: added: low-hanging-fruit
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers