Percona Server with XtraDB

log_block_checksum_is_ok_or_old_format() uses page not log block checksum algorithm

Reported by Laurynas Biveinis on 2013-11-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Status tracked in 5.6
5.1
Undecided
Unassigned
5.5
Undecided
Unassigned
5.6
Medium
Alexey Kopytov

Bug Description

log_block_checksum_is_ok_or_old_format uses srv_checksum_algorithm instead of srv_log_checksum_algorithm everywhere except the 1st use:

log_block_checksum_is_ok_or_old_format(...)
{
 if (UNIV_LIKELY(srv_log_checksum_algorithm ==
   SRV_CHECKSUM_ALGORITHM_NONE ||
   log_block_calc_checksum(block) == block_checksum)) {
...
 if (srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_STRICT_CRC32 ||
     srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_STRICT_INNODB ||
     srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_STRICT_NONE) {
...
 ut_ad(srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_CRC32 ||
       srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_INNODB);

Effectively meaning that this function will diagnose log block algorithms mismatch using the data page algorithm instead of log block algorithm.

Related branches

tags: added: low-hanging-fruit xtradb
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers