Unnecessary overhead from persistent adaptive hash index latches
|Percona Server||Status tracked in 5.6|
The server and InnoDB implement the following logic with respect to AHI latches acquired in row_search_
1. When row_search_
2. The latch is not normally released when InnoDB returns the control back to the server, i.e. is kept across multiple server calls into InnoDB.
3. The server may force InnoDB to release that latch later via ha_release_
4. The latch is also released by InnoDB on table open/close or transaction start/commit/
5. The latch is also released by InnoDB if it detects there are X waiters on the latch.
6. In which case it also releases the S latch acquired by row_search_
So it's quite a lot of work to have a persistent S latch and avoid contention on it at the same time. The question is why do we need to have a persistent lock in the first place. Comments in ha_release_
This function should be called when MySQL sends rows of a SELECT result set
or the EOF mark to the client. It releases a possible adaptive hash index
S-latch held by thd in InnoDB and also releases a possible InnoDB query
FIFO ticket to enter InnoDB. To save CPU time, InnoDB allows a thd to
keep them over several calls of the InnoDB handler interface when a join
is executed. But when we let the control to pass to the client they have
to be released because if the application program uses mysql_use_result(),
it may deadlock on the S-latch if the application on another connection
performs another SQL query. In MySQL-4.1 this is even more important because
there a connection can have several SELECT queries open at the same time.
It is unclear how much CPU time is saved in reality, given all the complications to avoid contention on the latch.
Also with AHI partitioning we have many latches to take care of, so the above logic becomes quite complicated, fragile, and is likely the reason for bugs like bug #1100760.
This report is to disable that persistent latches functionality.
- Laurynas Biveinis: Approve on 2013-09-06
- Diff: 1935 lines (+448/-373) 22 files modified (has conflicts)