5.6.12 removed UNIV_SYNC_DEBUG from UNIV_DEBUG
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MySQL Server |
Unknown
|
Unknown
|
|||
Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
5.1 |
Invalid
|
Undecided
|
Unassigned | ||
5.5 |
Invalid
|
Undecided
|
Unassigned | ||
5.6 |
Fix Released
|
Medium
|
Laurynas Biveinis |
Bug Description
[28 Jun 19:10] Laurynas Biveinis
Description:
univ.i has this new line in 5.6.12 compared to 5.6.11:
#undef UNIV_SYNC_DEBUG
Line 174.
Bzr annotate points to [1], whose commit message does not mention this rather big change, nor the commit itself looks like it would be related to locking in any way.
Is it an unintended change that should be reverted?
[1]
5.6$ bzr log -r 5058 -n0
-------
revno: 5058 [merge]
committer: Marko Mäkelä <email address hidden>
branch nick: mysql-5.6
timestamp: Tue 2013-04-30 14:45:16 +0300
message:
Merge mysql-5.5 to mysql-5.6.
---
revno: 2875.437.81
committer: Marko Mäkelä <email address hidden>
branch nick: mysql-5.5
timestamp: Tue 2013-04-30 13:39:50 +0300
message:
Bug#16720368 INNODB IGNORES *.IBD FILE BREAKAGE AT STARTUP
After a clean shutdown, InnoDB will not check the *.ibd file headers,
for maximum performance. This is unchanged before and after this
patch.
What this fix addresses is the case when crash recovery is
needed. Previously, InnoDB could load a corrupted tablespace file.
buf_
fil_
on the first page of a file. This can be overridden by setting
innodb_
fil_
fil_
open_
fil_
rb#2352 approved by Jimmy Yang
How to repeat:
Open univ.i, search for UNIV_SYNC_DEBUG
Suggested fix:
Remove the #undef.
Related branches
- Alexey Kopytov (community): Approve
-
Diff: 1897 lines (+678/-212)30 files modifiedPercona-Server/mysql-test/suite/innodb/r/percona_ahi_partitions.result (+33/-0)
Percona-Server/mysql-test/suite/innodb/t/percona_ahi_partitions-master.opt (+1/-0)
Percona-Server/mysql-test/suite/innodb/t/percona_ahi_partitions.test (+67/-0)
Percona-Server/mysql-test/suite/sys_vars/r/innodb_adaptive_hash_index_partitions_basic.result (+9/-0)
Percona-Server/mysql-test/suite/sys_vars/t/innodb_adaptive_hash_index_partitions_basic.test (+14/-0)
Percona-Server/storage/innobase/btr/btr0cur.cc (+6/-5)
Percona-Server/storage/innobase/btr/btr0sea.cc (+212/-117)
Percona-Server/storage/innobase/buf/buf0buf.cc (+3/-1)
Percona-Server/storage/innobase/dict/dict0dict.cc (+4/-2)
Percona-Server/storage/innobase/ha/ha0ha.cc (+30/-4)
Percona-Server/storage/innobase/handler/ha_innodb.cc (+7/-0)
Percona-Server/storage/innobase/handler/xtradb_i_s.cc (+28/-28)
Percona-Server/storage/innobase/include/btr0sea.h (+52/-2)
Percona-Server/storage/innobase/include/btr0sea.ic (+79/-2)
Percona-Server/storage/innobase/include/btr0types.h (+4/-4)
Percona-Server/storage/innobase/include/buf0buf.h (+2/-0)
Percona-Server/storage/innobase/include/mtr0log.ic (+1/-0)
Percona-Server/storage/innobase/include/que0que.h (+1/-0)
Percona-Server/storage/innobase/include/read0read.h (+1/-0)
Percona-Server/storage/innobase/include/trx0roll.h (+1/-0)
Percona-Server/storage/innobase/include/trx0trx.h (+1/-4)
Percona-Server/storage/innobase/include/trx0trx.ic (+8/-4)
Percona-Server/storage/innobase/include/univ.i (+0/-1)
Percona-Server/storage/innobase/os/os0file.cc (+1/-0)
Percona-Server/storage/innobase/row/row0sel.cc (+71/-24)
Percona-Server/storage/innobase/srv/srv0conc.cc (+1/-0)
Percona-Server/storage/innobase/srv/srv0srv.cc (+20/-13)
Percona-Server/storage/innobase/sync/sync0sync.cc (+19/-1)
Percona-Server/storage/innobase/trx/trx0trx.cc (+1/-0)
Percona-Server/storage/innobase/ut/ut0ut.cc (+1/-0)
tags: | added: innodb upstream |
Upstream fix in 5.6.16 and 5.7.4.