Missing branch predictor annotations for fake changes
Bug #1190604 reported by
Laurynas Biveinis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Low
|
Laurynas Biveinis | ||
| 5.1 |
Won't Fix
|
Low
|
Laurynas Biveinis | ||
| 5.5 |
Fix Released
|
Low
|
Laurynas Biveinis | ||
| 5.6 |
Fix Released
|
Low
|
Laurynas Biveinis | ||
Bug Description
Some, but not all, were fixed in the recent performance work. The fact that they weren't fixed there probably means they are not the worst offenders, but it's a good idea to maintain consistency.
Findable by grepping for "fake_change". Notable occurrences (i.e. more likely to be on hotter than colder code paths):
- in sql_insert.cc;
- in lock0lock.cc.
Related branches
lp:~laurynas-biveinis/percona-server/fake-changes-from-fb-5.5
- Stewart Smith (community): Approve
- Vlad Lesin (community): Approve (g2)
- Laurynas Biveinis: Pending requested
- Sergei Glushchenko: Pending (g2) requested
-
Diff: 1888 lines (+1082/-193)18 files modifiedPercona-Server/mysql-test/include/start_fake_changes.inc (+42/-0)
Percona-Server/mysql-test/include/stop_fake_changes.inc (+34/-0)
Percona-Server/mysql-test/r/percona_innodb_fake_changes.result (+485/-40)
Percona-Server/mysql-test/r/percona_innodb_fake_changes_bug_898306.result (+37/-3)
Percona-Server/mysql-test/r/percona_innodb_fake_changes_bug_917942.result (+101/-0)
Percona-Server/mysql-test/t/percona_innodb_fake_changes.test (+302/-73)
Percona-Server/mysql-test/t/percona_innodb_fake_changes_bug_898306.test (+8/-4)
Percona-Server/mysql-test/t/percona_innodb_fake_changes_bug_917942.test (+14/-24)
Percona-Server/mysql-test/t/percona_innodb_fake_changes_locks.test (+1/-0)
Percona-Server/sql/handler.cc (+1/-1)
Percona-Server/sql/sql_insert.cc (+1/-1)
Percona-Server/storage/innobase/btr/btr0cur.c (+11/-11)
Percona-Server/storage/innobase/handler/ha_innodb.cc (+12/-9)
Percona-Server/storage/innobase/handler/handler0alter.cc (+4/-4)
Percona-Server/storage/innobase/lock/lock0lock.c (+6/-6)
Percona-Server/storage/innobase/que/que0que.c (+1/-1)
Percona-Server/storage/innobase/row/row0ins.c (+7/-7)
Percona-Server/storage/innobase/row/row0upd.c (+15/-9)
lp:~laurynas-biveinis/percona-server/fake-changes-from-fb-5.6
- Stewart Smith (community): Approve
- Vlad Lesin (community): Approve (g2)
- Laurynas Biveinis: Pending requested
-
Diff: 2012 lines (+1268/-191)17 files modifiedPercona-Server/mysql-test/include/start_fake_changes.inc (+37/-0)
Percona-Server/mysql-test/include/stop_fake_changes.inc (+34/-0)
Percona-Server/mysql-test/r/percona_innodb_fake_changes.result (+606/-43)
Percona-Server/mysql-test/r/percona_innodb_fake_changes_bug_898306.result (+58/-3)
Percona-Server/mysql-test/r/percona_innodb_fake_changes_bug_917942.result (+154/-0)
Percona-Server/mysql-test/t/percona_innodb_fake_changes.test (+303/-76)
Percona-Server/mysql-test/t/percona_innodb_fake_changes_bug_898306.test (+10/-4)
Percona-Server/mysql-test/t/percona_innodb_fake_changes_bug_917942.test (+16/-24)
Percona-Server/mysql-test/t/percona_innodb_fake_changes_locks.test (+1/-0)
Percona-Server/sql/handler.cc (+1/-1)
Percona-Server/sql/sql_insert.cc (+1/-1)
Percona-Server/storage/innobase/btr/btr0cur.cc (+19/-16)
Percona-Server/storage/innobase/handler/ha_innodb.cc (+11/-9)
Percona-Server/storage/innobase/lock/lock0lock.cc (+4/-4)
Percona-Server/storage/innobase/que/que0que.cc (+1/-1)
Percona-Server/storage/innobase/row/row0ins.cc (+3/-2)
Percona-Server/storage/innobase/row/row0upd.cc (+9/-7)
| tags: | added: fake-changes performance xtradb |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/