Missing branch predictor annotations for fake changes

Bug #1190604 reported by Laurynas Biveinis on 2013-06-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Status tracked in 5.6
5.1
Low
Laurynas Biveinis
5.5
Low
Laurynas Biveinis
5.6
Low
Laurynas Biveinis

Bug Description

Some, but not all, were fixed in the recent performance work. The fact that they weren't fixed there probably means they are not the worst offenders, but it's a good idea to maintain consistency.

Findable by grepping for "fake_change". Notable occurrences (i.e. more likely to be on hotter than colder code paths):
- in sql_insert.cc;
- in lock0lock.cc.

Related branches

lp:~laurynas-biveinis/percona-server/fake-changes-from-fb-5.5
Stewart Smith (community): Approve on 2013-10-17
Vlad Lesin: Approve (g2) on 2013-09-30
Sergei Glushchenko: Pending (g2) requested 2013-07-29
Laurynas Biveinis: Pending requested 2013-07-29
lp:~laurynas-biveinis/percona-server/fake-changes-from-fb-5.6
Stewart Smith (community): Approve on 2013-10-17
Vlad Lesin: Approve (g2) on 2013-09-30
Laurynas Biveinis: Pending requested 2013-07-29
tags: added: fake-changes performance xtradb
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers