Optimization in buf_pool_get_oldest_modification if srv_buf_pool_instances == 1

Bug #1176496 reported by Laurynas Biveinis on 2013-05-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL Server
Unknown
Unknown
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Wishlist
Unassigned
5.1
Invalid
Undecided
Unassigned
5.5
Fix Released
Wishlist
Unassigned

Bug Description

buf_pool_get_oldest_modification() loops over all buffer pool instances, acquiring the flush list mutex for each of them.

Before the loop it enters the log flush order mutex:

 /* When we traverse all the flush lists we don't want another
 thread to add a dirty page to any flush list. */
 log_flush_order_mutex_enter();

In the case of srv_buf_pool_instances == 1 this is unnecessary as the flush list mutex will take care of it

tags: added: innodb
no longer affects: percona-server/5.6
Changed in percona-server:
status: Fix Committed → Fix Released
milestone: 5.6.11-60.3 → none
assignee: Laurynas Biveinis (laurynas-biveinis) → nobody

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2418

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.