Properly declare slow log support functions in sys_vars.cc for use in mysqld.cc

[Laurynas Biveinis]

Right now we have in mysqld.cc:

/* defined in sys_vars.cc */
extern void init_log_slow_verbosity();
extern void init_slow_query_log_use_global_control();

And in sys_vars.cc:

void init_log_slow_verbosity()
{
  update_slow_query_log_use_global_control(0,0,OPT_GLOBAL);
}

void init_slow_query_log_use_global_control()
{
  update_log_slow_verbosity(&(global_system_variables.log_slow_verbosity));
}

First, the titles / bodies of the functions seem to be swapped. That's benign because the functions are always called together.

Second, they should be declared in sys_vars.h instead of mysqld.cc. Perhaps it is the update_... functions that should be exported from sys_vars, and then init_ functions would be static to mysqld.cc.

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2001