Needless drop/reacquisition of fil_system->mutex

Bug #1146621 reported by Raghavendra D Prabhu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Invalid
Undecided
Unassigned
5.1
Invalid
Undecided
Unassigned
5.5
Fix Released
Low
Laurynas Biveinis
5.6
Invalid
Undecided
Unassigned

Bug Description

In fil_delete_tablespace, on either sides of the following fragment

 if (srv_lazy_drop_table) {
  buf_LRU_mark_space_was_deleted(id);
 } else {
 buf_LRU_flush_or_remove_pages(
  id, evict_all
  ? BUF_REMOVE_ALL_NO_WRITE
  : BUF_REMOVE_FLUSH_NO_WRITE);

 }

it drops and reacquires fil_system->mutex which shouldn't be required if srv_lazy_drop_table is TRUE, since in buf_LRU_mark_space_was_deleted that mutex is not checked/acquired and LRU list mutex is instead used.

Revision history for this message
Raghavendra D Prabhu (raghavendra-prabhu) wrote :

Now that lazy drop table has been removed, I think this bug can be closed as well.

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2905

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.