Percona Server with XtraDB

Needless drop/reacquisition of fil_system->mutex

Reported by Raghavendra D Prabhu on 2013-03-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Status tracked in 5.6
5.1
Undecided
Unassigned
5.5
Low
Laurynas Biveinis
5.6
Undecided
Unassigned

Bug Description

In fil_delete_tablespace, on either sides of the following fragment

 if (srv_lazy_drop_table) {
  buf_LRU_mark_space_was_deleted(id);
 } else {
 buf_LRU_flush_or_remove_pages(
  id, evict_all
  ? BUF_REMOVE_ALL_NO_WRITE
  : BUF_REMOVE_FLUSH_NO_WRITE);

 }

it drops and reacquires fil_system->mutex which shouldn't be required if srv_lazy_drop_table is TRUE, since in buf_LRU_mark_space_was_deleted that mutex is not checked/acquired and LRU list mutex is instead used.

Now that lazy drop table has been removed, I think this bug can be closed as well.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers