Percona Server with XtraDB

Suboptimal code in skip_trailing_space()

Reported by Alexey Kopytov on 2013-02-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL Server
Unknown
Unknown
Percona Server
Status tracked in 5.6
5.1
Undecided
Unassigned
5.5
Medium
Alexey Kopytov
5.6
Medium
Laurynas Biveinis

Bug Description

The skip_trailing_space() implementation is suboptimal. 2 problems:

- it assumes SIZEOF_INT to be the machine word length. So it processes
  the string by 4-byte words even on 64-bit machines. It should
  actually be SIZEOF_LONG as it's normally the real machine word length.

- it is unnecessary brachy. Too many "if"s and loops for such a simple code.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.