dec_connection_count() definition doesn't match its declaration

Bug #1131856 reported by Alexey Kopytov on 2013-02-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Status tracked in 5.7
5.5
Triaged
High
Unassigned
5.6
Invalid
Undecided
Unassigned
5.7
Invalid
Undecided
Unassigned

Bug Description

dec_connection_count() is declared in include/thread_pool_priv.h as follows:

/* Decrement connection counter */
void dec_connection_count();

However, the threadpool patch has added the 'thd' argument to the definition without changing the declaration:

void dec_connection_count(THD *thd)
{
  mysql_mutex_lock(&LOCK_connection_count);
  (*thd->scheduler->connection_count)--;
  mysql_mutex_unlock(&LOCK_connection_count);
}

summary: - dec_thread_count() definition doesn't match its declaration
+ dec_connection_count() definition doesn't match its declaration
description: updated
tags: added: low-hanging-fruit

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2898

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers