Remove malloc() from read_view_create_low()
Bug #1131187 reported by
Alexey Kopytov
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MySQL Server |
Unknown
|
Unknown
|
|||
Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
High
|
Alexey Kopytov | ||
5.1 |
Won't Fix
|
Undecided
|
Unassigned | ||
5.5 |
Fix Released
|
High
|
Alexey Kopytov | ||
5.6 |
Fix Released
|
High
|
Alexey Kopytov |
Bug Description
read_view_
The problem is that the heap for that allocation is emptied on each commit and thus read view memory is reallocated on the next transaction. Memory profiling shows that memory allocated by read_view_
Related branches
lp:~akopytov/percona-server/bug1131187
- Stewart Smith (community): Approve
-
Diff: 327 lines (+75/-37)7 files modifiedPercona-Server/storage/innobase/include/read0read.h (+14/-4)
Percona-Server/storage/innobase/include/trx0purge.h (+1/-0)
Percona-Server/storage/innobase/include/trx0trx.h (+1/-3)
Percona-Server/storage/innobase/read/read0read.c (+45/-16)
Percona-Server/storage/innobase/row/row0sel.c (+1/-1)
Percona-Server/storage/innobase/trx/trx0purge.c (+6/-3)
Percona-Server/storage/innobase/trx/trx0trx.c (+7/-10)
lp:~akopytov/percona-server/bug1131187-5.6
- Laurynas Biveinis (community): Approve
-
Diff: 424 lines (+113/-73)7 files modifiedPercona-Server/storage/innobase/include/read0read.h (+17/-4)
Percona-Server/storage/innobase/include/trx0purge.h (+4/-0)
Percona-Server/storage/innobase/include/trx0trx.h (+1/-3)
Percona-Server/storage/innobase/read/read0read.cc (+79/-51)
Percona-Server/storage/innobase/row/row0sel.cc (+1/-1)
Percona-Server/storage/innobase/trx/trx0purge.cc (+7/-2)
Percona-Server/storage/innobase/trx/trx0trx.cc (+4/-12)
To post a comment you must log in.
I will port it to 5.6 myself.