Broken filtering out of InnoDB stats in mysqldumpslow

Bug #1097692 reported by Laurynas Biveinis on 2013-01-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Undecided
Laurynas Biveinis
5.1
Undecided
Laurynas Biveinis
5.5
Undecided
Laurynas Biveinis
5.6
Undecided
Laurynas Biveinis

Bug Description

The regexps that filter out the InnoDB stats do not handle the case of the waiting times happening to be integer values, resulting in sporadic extraneous lines in mysqldumpslow output.

Fix:

--- Percona-Server/scripts/mysqldumpslow.sh 2012-01-30 04:30:33 +0000
+++ Percona-Server/scripts/mysqldumpslow.sh 2013-01-09 11:27:48 +0000
@@ -126,9 +126,9 @@

     s/^# Filesort: \S+ Filesort_on_disk: \S+ Merge_passes: \S+\n//;

- s/^# InnoDB_IO_r_ops: \d+ InnoDB_IO_r_bytes: \d+ InnoDB_IO_r_wait: \d+\.\d+\n//;
+ s/^# InnoDB_IO_r_ops: \d+ InnoDB_IO_r_bytes: \d+ InnoDB_IO_r_wait: \d+(\.\d+)?\n//;

- s/^# InnoDB_rec_lock_wait: \d+\.\d+ InnoDB_queue_wait: \d+\.\d+\n//;
+ s/^# InnoDB_rec_lock_wait: \d+(\.\d+)? InnoDB_queue_wait: \d+(\.\d+)?\n//;

     s/^# InnoDB_pages_distinct: \d+\n//;

Related branches

lp:~laurynas-biveinis/percona-server/slow-log-fixes-5.1
Merged into lp:percona-server/5.1 at revision 529
Stewart Smith (community): Approve on 2013-02-11
tags: added: slow-extended
Changed in percona-server:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers