Percona Server with XtraDB

Missing mutex != NULL check in i_s_innodb_fill_buffer_pool()

Reported by Laurynas Biveinis on 2012-10-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Status tracked in 5.6
5.1
High
Stewart Smith
5.5
High
Stewart Smith
5.6
Undecided
Unassigned

Bug Description

Taking this from the MP review as it was submitted too late:

My previous review comment was misleading, sorry about that: buf_page_get_mutex_enter() is better than buf_page_get_mutex() and mutex_enter() combination by preventing a race condition between the calls and not calling mutex_enter on NULL. But it still might return NULL, thus mutex_exit() still has to be conditional in i_s_innodb_fill_buffer_pool().

And for 5.1:

i_s_innodb_fill_buffer_pool() still acquires the buffer pool mutex (and has a comment block above it).

Also, mutex_exit() in it should be conditional on block_mutex != NULL.

tags: added: xtradb
tags: added: merge-regression
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers