Percona Server with XtraDB

Missing mutex != NULL check in i_s_innodb_fill_buffer_pool()

Bug #1072573 reported by Laurynas Biveinis on 2012-10-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server
Status tracked in 5.6
​ 5.1
Fix Released
High
Stewart Smith
Percona Server 5.1.70-14.8
​ 5.5
Fix Released
High
Stewart Smith
Percona Server 5.5.32-31.0
​ 5.6
Invalid
Undecided
Unassigned
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

Taking this from the MP review as it was submitted too late:

My previous review comment was misleading, sorry about that: buf_page_get_mutex_enter() is better than buf_page_get_mutex() and mutex_enter() combination by preventing a race condition between the calls and not calling mutex_enter on NULL. But it still might return NULL, thus mutex_exit() still has to be conditional in i_s_innodb_fill_buffer_pool().

Laurynas Biveinis (laurynas-biveinis) wrote :

And for 5.1:

i_s_innodb_fill_buffer_pool() still acquires the buffer pool mutex (and has a comment block above it).

Also, mutex_exit() in it should be conditional on block_mutex != NULL.

Laurynas Biveinis (laurynas-biveinis) on 2013-02-05
tags: added: xtradb
Laurynas Biveinis (laurynas-biveinis) on 2013-02-26
tags: added: merge-regression
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers