[DOC] duplicate value in allowed values for innodb_adaptive_flushing_method

[Volans]

[In:Percona Server Documentation]

The documentation for the variable "innodb_adaptive_flushing_method" have a duplicate value for the allowed values:

    native, reflex, estimate, keep_average, native (or 0/1/2/3, respectively, for compatibility)

should be replaced with:

    native, reflex, estimate, keep_average (or 0/1/2/3, respectively, for compatibility)

OR

    reflex, estimate, keep_average, native (or 0/1/2/3, respectively, for compatibility)

depending on the order for the compatibility of the integer syntax.
Maybe should be more clear to specify the exact integer value for each allowed value.

I have found it in the "Improved InnoDB I/O Scalability" ( http://www.percona.com/doc/percona-server/5.5/scalability/innodb_io_55.html#innodb_adaptive_flushing_method ) page, but can be elsewhere too.

[Volans (volans)]

In the page ( http://www.percona.com/doc/percona-server/5.5/scalability/innodb_io_55.html#innodb_adaptive_flushing_method ) now the "reflex" allowed value is now missing from the allowed values, but is present in the long description just below.

Moreover the "reflex" value description does not have the corresponding integer value indicated.

I will reopen the bug report.

[Volans (volans)]

See comment 1 below

[Raghavendra D Prabhu (raghavendra-prabhu)]

@Volans,

That is because there no longer is a 'reflex' method for flushing.

const char *adaptive_flushing_method_names[]=
{
  "native", /* 0 */
  "estimate", /* 1 */
  "keep_average", /* 2 */
  /* For compatibility of the older patch */
  "0", /* 3 ("none" + 3) */
  "1", /* 4 ("estimate" + 3) */
  "2", /* 5 ("keep_average" + 3) */
  NullS
};

I guess for reflex description following should be in bold / in beginning.
"This method was removed in 5.5.20-beta as a fix for bug #689450."

[Volans (volans)]

You are right, sorry for the re-opening... I don't have seen the notice about the removed method. Probably yes, it should be moved below all the valid values and with a bold notice.

Thank you for your reply

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2775