Still fails for me, but in a different way now. I know it's because I compiled without thread pool support. But I think we still want the test to pass in this case.
main.mysqld--help-notwin [ fail ]
Test ended at 2011-05-31 08:45:58
CURRENT_TEST: main.mysqld--help-notwin
--- /Users/kaa/src/launchpad/mysql-55-eb/mysql-test/r/mysqld--help-notwin.result 2011-05-28 17:58:39.000000000 +0300
+++ /Users/kaa/src/launchpad/mysql-55-eb/mysql-test/r/mysqld--help-notwin.reject 2011-05-31 07:45:58.000000000 +0300
@@ -707,9 +707,6 @@
Define threads usage for handling queries, one of
one-thread-per-connection, no-threads,
loaded-dynamically, pool-of-threads
- --thread-pool-size=#
- How many threads we should create to handle query
- requests in case of 'thread_handling=pool-of-threads'.
--thread-stack=# The stack size for each thread
--time-format=name The TIME format (ignored)
--timed-mutexes Specify whether to time mutexes (only InnoDB mutexes are
@@ -956,7 +953,6 @@
tc-heuristic-recover COMMIT
thread-cache-size 0
thread-handling one-thread-per-connection
-thread-pool-size 20
thread-stack 262144
time-format %H:%i:%s
timed-mutexes FALSE
I suggest we add thread-pool-size to the list of ignored variables (@skipvars in include/mysqld--help.inc) and update the .result file accordingly. That is:
# Plugins which may or may not be there:
@plugins=qw/innodb ndb archive blackhole federated partition ndbcluster debug temp-pool ssl des-key-file
=== modified file 'mysql-test/r/mysqld--help-notwin.result'
--- mysql-test/r/mysqld--help-notwin.result 2011-05-27 10:29:52 +0000
+++ mysql-test/r/mysqld--help-notwin.result 2011-05-31 04:48:59 +0000
@@ -707,9 +707,6 @@
Define threads usage for handling queries, one of
one-thread-per-connection, no-threads,
loaded-dynamically, pool-of-threads
- --thread-pool-size=#
- How many threads we should create to handle query
- requests in case of 'thread_handling=pool-of-threads'.
--thread-stack=# The stack size for each thread
--time-format=name The TIME format (ignored)
--timed-mutexes Specify whether to time mutexes (only InnoDB mutexes are
@@ -956,7 +953,6 @@ table-open-cache 400
tc-heuristic-recover COMMIT
thread-cache-size 0
thread-handling one-thread-per-connection
-thread-pool-size 20
thread-stack 262144
time-format %H:%i:%s
timed-mutexes FALSE
Still fails for me, but in a different way now. I know it's because I compiled without thread pool support. But I think we still want the test to pass in this case.
main.mysqld- -help-notwin [ fail ]
Test ended at 2011-05-31 08:45:58
CURRENT_TEST: main.mysqld- -help-notwin kaa/src/ launchpad/ mysql-55- eb/mysql- test/r/ mysqld- -help-notwin. result 2011-05-28 17:58:39.000000000 +0300 kaa/src/ launchpad/ mysql-55- eb/mysql- test/r/ mysqld- -help-notwin. reject 2011-05-31 07:45:58.000000000 +0300 per-connection, no-threads, dynamically, pool-of-threads pool-size= # handling= pool-of- threads' . format= name The TIME format (ignored) recover COMMIT per-connection
--- /Users/
+++ /Users/
@@ -707,9 +707,6 @@
Define threads usage for handling queries, one of
one-thread-
loaded-
- --thread-
- How many threads we should create to handle query
- requests in case of 'thread_
--thread-stack=# The stack size for each thread
--time-
--timed-mutexes Specify whether to time mutexes (only InnoDB mutexes are
@@ -956,7 +953,6 @@
tc-heuristic-
thread-cache-size 0
thread-handling one-thread-
-thread-pool-size 20
thread-stack 262144
time-format %H:%i:%s
timed-mutexes FALSE
I suggest we add thread-pool-size to the list of ignored variables (@skipvars in include/ mysqld- -help.inc) and update the .result file accordingly. That is:
=== modified file 'mysql- test/include/ mysqld- -help.inc' include/ mysqld- -help.inc 2010-09-30 13:52:39 +0000 include/ mysqld- -help.inc 2011-05-31 04:48:12 +0000 qw/basedir open-files-limit general-log-file log plugin-dir
log-slow- queries pid-file slow-query-log-file
--- mysql-test/
+++ mysql-test/
@@ -18,7 +18,8 @@ perl;
# their paths may vary:
@skipvars=
- datadir slave-load-tmpdir tmpdir socket/;
+ datadir slave-load-tmpdir tmpdir socket
+ thread-pool-size/;
# Plugins which may or may not be there: qw/innodb ndb archive blackhole federated partition ndbcluster debug temp-pool ssl des-key-file
@plugins=
=== modified file 'mysql- test/r/ mysqld- -help-notwin. result' r/mysqld- -help-notwin. result 2011-05-27 10:29:52 +0000 r/mysqld- -help-notwin. result 2011-05-31 04:48:59 +0000 per-connection, no-threads, dynamically, pool-of-threads pool-size= # handling= pool-of- threads' . format= name The TIME format (ignored) recover COMMIT per-connection
--- mysql-test/
+++ mysql-test/
@@ -707,9 +707,6 @@
Define threads usage for handling queries, one of
one-thread-
loaded-
- --thread-
- How many threads we should create to handle query
- requests in case of 'thread_
--thread-stack=# The stack size for each thread
--time-
--timed-mutexes Specify whether to time mutexes (only InnoDB mutexes are
@@ -956,7 +953,6 @@ table-open-cache 400
tc-heuristic-
thread-cache-size 0
thread-handling one-thread-
-thread-pool-size 20
thread-stack 262144
time-format %H:%i:%s
timed-mutexes FALSE