Leverage lock-free SHOW SLAVE STATUS NONBLOCKING as well

Bug #1380690 reported by Roman Vynar
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona Monitoring Plugins
Fix Released
Medium
Unassigned

Bug Description

Previously, we implemented a lock-free SHOW SLAVE STATUS NOLOCK.
However, it was recently changed to SHOW SLAVE STATUS NONBLOCKING in Percona Server 5.6 to be consistent with MySQL 5.7 syntax.
http://www.percona.com/doc/percona-server/5.6/reliability/show_slave_status_nolock.html

Changed in percona-monitoring-plugins:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Roman Vynar (roman-vynar) wrote :

* docs/cacti/mysql-templates.rst
* cacti/scripts/ss_get_mysql_stats.php
* nagios/bin/pmp-check-mysql-replication-delay
* nagios/bin/pmp-check-mysql-replication-running

Revision history for this message
monty solomon (monty+launchpad) wrote :

FYI, the NONBLOCKING option was removed in 5.7.6.

Excerpt from

http://dev.mysql.com/doc/refman/5.7/en/show-slave-status.html
This option was removed in MySQL 5.7.6 due to locking changes that render it unnecessary.

Revision history for this message
Roman Vynar (roman-vynar) wrote :

Thanks monty!

Revision history for this message
monty solomon (monty+launchpad) wrote :

SHOW SLAVE STATUS NOLOCK/NONBLOCKING is no longer needed as of 5.6.23.

The hanging SHOW SLAVE STATUS issue (bug #1386363) was fixed in 5.6.23.

Revision history for this message
Roman Vynar (roman-vynar) wrote :

Awesome!

Revision history for this message
Roman Vynar (roman-vynar) wrote :

Per discussion with Laurynas about bug #1386363, that bug avoids a different lock than NONBLOCKING.
So I think I will try to iterate over those commands in order until first success:
- show slave status nonblocking
- show slave status nolock
- show slave status

Shouldn't be any harm and it will account all possible setups/versions.

summary: - Change to lock-Free SHOW SLAVE STATUS NONBLOCKING
+ Leverage lock-free SHOW SLAVE STATUS NONBLOCKING as well
Changed in percona-monitoring-plugins:
status: Confirmed → Fix Committed
Changed in percona-monitoring-plugins:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.